Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 10388163: [cros] Put back GAIA extension updated manifest, now with fix. (Closed)

Created:
8 years, 7 months ago by Nikita (slow)
Modified:
8 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Visibility:
Public.

Description

[cros] Put back GAIA extension updated manifest, now with fix. Revert 137423 - Revert 137165 - Added CSP to GAIA auth extension. Needs to land after https://gerrit.chromium.org/gerrit/#change,22663. Reason: Manifest error + CSP issues still remain http://crbug.com/128261#c8 BUG=chromium:127221 TEST=make sure ChromeOS auth + autotests still work Review URL: https://chromiumcodereview.appspot.com/10398031 TBR=zelidrag@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388162 TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137431

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/browser/resources/chromeos/gaia_auth/manifest.json View 1 1 chunk +13 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/gaia_auth/manifest_test.json View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nikita (slow)
8 years, 7 months ago (2012-05-16 15:30:05 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698