Issue 10398031: Added CSP to GAIA auth extension. Needs to land after https://gerrit.chromium.org/gerrit/#change,22…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10398031: Added CSP to GAIA auth extension. Needs to land after https://gerrit.chromium.org/gerrit/#change,22… (Closed)

Created:
8 years, 7 months ago by zel

Modified:
8 years, 7 months ago

Reviewers:
xiyuan, jimhebert, Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added CSP to GAIA auth extension. Needs to land after https://gerrit.chromium.org/gerrit/#change,22663. BUG=chromium:127221 TEST=make sure ChromeOS auth + autotests still work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137165

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	chrome/browser/resources/chromeos/gaia_auth/manifest.json	View		1 chunk	+13 lines, -1 line	1 comment	Download
	M	chrome/browser/resources/chromeos/gaia_auth/manifest_test.json	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10398031/1

8 years, 7 months ago (2012-05-15 16:04:30 UTC) #3

Nikita (slow)

8 years, 7 months ago (2012-05-16 14:45:18 UTC) #5

https://chromiumcodereview.appspot.com/10398031/diff/1/chrome/browser/resourc...
File chrome/browser/resources/chromeos/gaia_auth/manifest.json (right):

https://chromiumcodereview.appspot.com/10398031/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/gaia_auth/manifest.json:18: "util.js",
Line: 19, column: 3, Trailing comma not allowed.

Expand Messages | Collapse Messages