[NTP4] Fix appmarklet animation drop bug.

[NTP4] Fix appmarklet animation drop bug.

R=estade@chromium.org
BUG=128118
TEST=Create an appmarklet via d'n'd on the NTP, make sure it bounces in.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137199

[Dan Beam, 2012-05-15 01:24:38]

added a fix for most visited -> apps page dragging animations as well

[Dan Beam, 2012-05-15 01:46:03]

https://chromiumcodereview.appspot.com/10388134/diff/5/chrome/browser/resourc...
File chrome/browser/resources/ntp4/apps_page.js (left):

https://chromiumcodereview.appspot.com/10388134/diff/5/chrome/browser/resourc...
chrome/browser/resources/ntp4/apps_page.js:756:
this.setDropEffect(e.dataTransfer);
this was avoiding calling TilePage#updateDropIndicator_, which caused the UI not
to reserve drop space for a dragging most visited tile, so I removed this
override (and just let this fall back to TilePage#doDragOver). if this was
intentional (for some reason), I can revert this hunk...

[Evan Stade, 2012-05-15 03:01:10]

http://codereview.chromium.org/10388134/diff/5/chrome/browser/resources/ntp4/...
File chrome/browser/resources/ntp4/apps_page.js (left):

http://codereview.chromium.org/10388134/diff/5/chrome/browser/resources/ntp4/...
chrome/browser/resources/ntp4/apps_page.js:756:
this.setDropEffect(e.dataTransfer);
On 2012/05/15 01:46:03, Dan Beam wrote:
> this was avoiding calling TilePage#updateDropIndicator_, which caused the UI
not
> to reserve drop space for a dragging most visited tile, so I removed this
> override (and just let this fall back to TilePage#doDragOver). if this was
> intentional (for some reason), I can revert this hunk...

yes this is intentional, you will notice that most visited tiles always get
dropped at the end (if you need to know why I can explain offline)

[Dan Beam, 2012-05-15 04:00:44]

ptal

http://codereview.chromium.org/10388134/diff/5/chrome/browser/resources/ntp4/...
File chrome/browser/resources/ntp4/apps_page.js (left):

http://codereview.chromium.org/10388134/diff/5/chrome/browser/resources/ntp4/...
chrome/browser/resources/ntp4/apps_page.js:756:
this.setDropEffect(e.dataTransfer);
On 2012/05/15 03:01:11, Evan Stade wrote:
> On 2012/05/15 01:46:03, Dan Beam wrote:
> > this was avoiding calling TilePage#updateDropIndicator_, which caused the UI
> not
> > to reserve drop space for a dragging most visited tile, so I removed this
> > override (and just let this fall back to TilePage#doDragOver). if this was
> > intentional (for some reason), I can revert this hunk...
> 
> yes this is intentional, you will notice that most visited tiles always get
> dropped at the end (if you need to know why I can explain offline)

OK, fixed outside data handling to match.

[Evan Stade, 2012-05-15 04:17:17]

lgtm

[commit-bot: I haz the power, 2012-05-15 06:14:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/10388134/10001

[commit-bot: I haz the power, 2012-05-15 07:17:23]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is android, revision is 137081, job name
was 10388134-10001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

[commit-bot: I haz the power, 2012-05-15 17:23:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/10388134/10001

[commit-bot: I haz the power, 2012-05-15 19:13:53]

Change committed as 137199