Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3719)

Unified Diff: chrome/browser/resources/ntp4/tile_page.js

Issue 10388134: [NTP4] Fix appmarklet animation drop bug. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: estade review / behavior change Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp4/page_list_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/tile_page.js
diff --git a/chrome/browser/resources/ntp4/tile_page.js b/chrome/browser/resources/ntp4/tile_page.js
index 7da6cb1ed753554c39c9ba3d9bf2dcd28d83a810..0b148331fa146919bb028be07fbb4c61879a8cf3 100644
--- a/chrome/browser/resources/ntp4/tile_page.js
+++ b/chrome/browser/resources/ntp4/tile_page.js
@@ -558,7 +558,7 @@ cr.define('ntp', function() {
/**
* Appends a tile to the end of the tile grid.
* @param {HTMLElement} tileElement The contents of the tile.
- * @param {?boolean} animate If true, the append will be animated.
+ * @param {boolean} animate If true, the append will be animated.
* @protected
*/
appendTile: function(tileElement, animate) {
@@ -569,13 +569,13 @@ cr.define('ntp', function() {
* Adds the given element to the tile grid.
* @param {Node} tileElement The tile object/node to insert.
* @param {number} index The location in the tile grid to insert it at.
- * @param {boolean=} opt_animate If true, the tile in question will be
+ * @param {boolean} animate If true, the tile in question will be
* animated (other tiles, if they must reposition, do not animate).
* @protected
*/
- addTileAt: function(tileElement, index, opt_animate) {
+ addTileAt: function(tileElement, index, animate) {
this.classList.remove('animating-tile-page');
- if (opt_animate)
+ if (animate)
tileElement.classList.add('new-tile-contents');
// Make sure the index is positive and either in the the bounds of
@@ -590,7 +590,7 @@ cr.define('ntp', function() {
this.heightChanged_();
this.repositionTiles_();
- this.fireAddedEvent(wrapperDiv, index, !!opt_animate);
+ this.fireAddedEvent(wrapperDiv, index, animate);
},
/**
@@ -1170,7 +1170,6 @@ cr.define('ntp', function() {
* @param {Event} e A mouseover event for the drag enter.
*/
doDragEnter: function(e) {
-
// Applies the mask so doppleganger tiles disappear into the fog.
this.updateMask_();
« no previous file with comments | « chrome/browser/resources/ntp4/page_list_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698