Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10388105: aura: Fix a couple of bug (really the same bug at two different places) for drag (Closed)

Created:
8 years, 7 months ago by varunjain
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

aura: Fix a couple of bug (really the same bug at two different places) for drag and drop: WebKit needs a DragEntered before a Drop. So we guarantee this in aura's DnD implementation. BUG=121232 TEST=no crash during drag and drop on a webpage Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137015

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 4 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
varunjain
8 years, 7 months ago (2012-05-11 23:31:53 UTC) #1
sky
https://chromiumcodereview.appspot.com/10388105/diff/1/content/browser/web_contents/web_contents_view_aura.h File content/browser/web_contents/web_contents_view_aura.h (right): https://chromiumcodereview.appspot.com/10388105/diff/1/content/browser/web_contents/web_contents_view_aura.h#newcode145 content/browser/web_contents/web_contents_view_aura.h:145: content::RenderViewHost* current_rvh_for_drag_; Can you make this a void*?
8 years, 7 months ago (2012-05-14 13:57:15 UTC) #2
varunjain
https://chromiumcodereview.appspot.com/10388105/diff/1/content/browser/web_contents/web_contents_view_aura.h File content/browser/web_contents/web_contents_view_aura.h (right): https://chromiumcodereview.appspot.com/10388105/diff/1/content/browser/web_contents/web_contents_view_aura.h#newcode145 content/browser/web_contents/web_contents_view_aura.h:145: content::RenderViewHost* current_rvh_for_drag_; On 2012/05/14 13:57:15, sky wrote: > Can ...
8 years, 7 months ago (2012-05-14 17:31:07 UTC) #3
sky
LGTM
8 years, 7 months ago (2012-05-14 20:51:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10388105/5001
8 years, 7 months ago (2012-05-14 20:52:02 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-14 23:50:28 UTC) #6 
Change committed as 137015

Powered by Google App Engine
This is Rietveld 408576698