Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: ash/drag_drop/drag_drop_controller_unittest.cc

Issue 10388105: aura: Fix a couple of bug (really the same bug at two different places) for drag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/drag_drop/drag_drop_controller.h" 5 #include "ash/drag_drop/drag_drop_controller.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shell.h"
8 #include "ash/test/ash_test_base.h" 8 #include "ash/test/ash_test_base.h"
9 #include "ash/wm/root_window_event_filter.h" 9 #include "ash/wm/root_window_event_filter.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 for (int i = 0; i < num_drags; ++i) { 267 for (int i = 0; i < num_drags; ++i) {
268 // Because we are not doing a blocking drag and drop, the original 268 // Because we are not doing a blocking drag and drop, the original
269 // OSDragExchangeData object is lost as soon as we return from the drag 269 // OSDragExchangeData object is lost as soon as we return from the drag
270 // initiation in DragDropController::StartDragAndDrop(). Hence we set the 270 // initiation in DragDropController::StartDragAndDrop(). Hence we set the
271 // drag_data_ to a fake drag data object that we created. 271 // drag_data_ to a fake drag data object that we created.
272 if (i > 0) 272 if (i > 0)
273 UpdateDragData(&data); 273 UpdateDragData(&data);
274 generator.MoveMouseBy(0, 1); 274 generator.MoveMouseBy(0, 1);
275 } 275 }
276 276
277 UpdateDragData(&data);
278
277 generator.ReleaseLeftButton(); 279 generator.ReleaseLeftButton();
278 280
279 EXPECT_TRUE(drag_drop_controller_->drag_start_received_); 281 EXPECT_TRUE(drag_drop_controller_->drag_start_received_);
280 EXPECT_EQ(num_drags - 1 - drag_view->VerticalDragThreshold(), 282 EXPECT_EQ(num_drags - 1 - drag_view->VerticalDragThreshold() + 1,
281 drag_drop_controller_->num_drag_updates_); 283 drag_drop_controller_->num_drag_updates_);
282 EXPECT_TRUE(drag_drop_controller_->drop_received_); 284 EXPECT_TRUE(drag_drop_controller_->drop_received_);
283 285
284 EXPECT_EQ(0, drag_view->num_drag_enters_); 286 EXPECT_EQ(1, drag_view->num_drag_enters_);
285 EXPECT_EQ(num_drags - 1 - drag_view->VerticalDragThreshold(), 287 EXPECT_EQ(num_drags - 1 - drag_view->VerticalDragThreshold() + 1,
286 drag_view->num_drag_updates_); 288 drag_view->num_drag_updates_);
287 EXPECT_EQ(0, drag_view->num_drops_); 289 EXPECT_EQ(1, drag_view->num_drops_);
288 EXPECT_EQ(0, drag_view->num_drag_exits_); 290 EXPECT_EQ(0, drag_view->num_drag_exits_);
289 EXPECT_TRUE(drag_view->drag_done_received_); 291 EXPECT_TRUE(drag_view->drag_done_received_);
290 } 292 }
291 293
292 TEST_F(DragDropControllerTest, DragDropInMultipleViewsSingleWidgetTest) { 294 TEST_F(DragDropControllerTest, DragDropInMultipleViewsSingleWidgetTest) {
293 scoped_ptr<views::Widget> widget(CreateNewWidget()); 295 scoped_ptr<views::Widget> widget(CreateNewWidget());
294 DragTestView* drag_view1 = new DragTestView; 296 DragTestView* drag_view1 = new DragTestView;
295 AddViewToWidgetAndResize(widget.get(), drag_view1); 297 AddViewToWidgetAndResize(widget.get(), drag_view1);
296 DragTestView* drag_view2 = new DragTestView; 298 DragTestView* drag_view2 = new DragTestView;
297 AddViewToWidgetAndResize(widget.get(), drag_view2); 299 AddViewToWidgetAndResize(widget.get(), drag_view2);
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 EXPECT_EQ(1, drag_view->num_drag_enters_); 581 EXPECT_EQ(1, drag_view->num_drag_enters_);
580 EXPECT_EQ(num_drags - 1 - drag_view->VerticalDragThreshold(), 582 EXPECT_EQ(num_drags - 1 - drag_view->VerticalDragThreshold(),
581 drag_view->num_drag_updates_); 583 drag_view->num_drag_updates_);
582 EXPECT_EQ(1, drag_view->num_drops_); 584 EXPECT_EQ(1, drag_view->num_drops_);
583 EXPECT_EQ(0, drag_view->num_drag_exits_); 585 EXPECT_EQ(0, drag_view->num_drag_exits_);
584 EXPECT_TRUE(drag_view->drag_done_received_); 586 EXPECT_TRUE(drag_view->drag_done_received_);
585 } 587 }
586 588
587 } // namespace test 589 } // namespace test
588 } // namespace aura 590 } // namespace aura
OLDNEW
« no previous file with comments | « ash/drag_drop/drag_drop_controller.cc ('k') | content/browser/web_contents/web_contents_view_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698