Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10388084: Better support for the case of typed arrays inheriting from other typed arrays. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/systeminterface.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index ce44203b7e151aa64194bff285ec4abe05a5aa67..8bdb1791c7a0740e1153cdcf1bfcef21882292ae 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -247,6 +247,13 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):
self._GenerateConstructors()
+ # Ugly corner case: in WebKit Uint8ClampedArray inherits from Uint8Array,
podivilov 2012/05/11 12:34:44 Please use AddIndexer. Looks like we need to fork
podivilov 2012/05/11 14:18:17 Done.
+ # but Uint8Array::{g,s}et is not virtual, so one needs to have an override
+ # for operator[] and operator[]= for Uint8ClampedArray.
+ if self._interface.id == 'Uint8ClampedArray':
+ self._EmitNativeIndexGetter(self._interface, 'int')
+ self._EmitNativeIndexSetter(self._interface, 'int')
+
def _GenerateConstructors(self):
if not self._IsConstructable():
return
« no previous file with comments | « lib/dom/scripts/systeminterface.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698