Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 10388083: Apply system default theme for OOBE screen. (Closed)

Created:
8 years, 7 months ago by kochi
Modified:
8 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
wiltzius, chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Apply system default theme for OOBE screen. BUG=chromium:124427 TEST=run OOBE on ChromeOS and see if active item under the pointer on select menu or selected text in textfield is rendered properly (fg: black, bg:lightblue). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kochi
Hi Nikita, This seems to fix the issue, but I'm not familiar with the code ...
8 years, 7 months ago (2012-05-11 10:43:25 UTC) #1
Nikita (slow)
lgtm
8 years, 7 months ago (2012-05-11 14:38:22 UTC) #2
Nikita (slow)
Thanks for investigating this issue!
8 years, 7 months ago (2012-05-11 14:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10388083/1
8 years, 7 months ago (2012-05-11 15:00:50 UTC) #4
commit-bot: I haz the power
Try job failure for 10388083-1 (retry) on linux_rel for steps "base_unittests, browser_tests, net_unittests" (clobber build). ...
8 years, 7 months ago (2012-05-11 16:06:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10388083/1
8 years, 7 months ago (2012-05-12 00:26:42 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-12 01:43:57 UTC) #7
Change committed as 136737

Powered by Google App Engine
This is Rietveld 408576698