Add GetImageSkiaNamed to resource_bundle and theme_provider

Add GetImageSkiaNamed to resource_bundle and theme_provider.
This makes converting use of SkBitmap into ImageSkia easier

Bug=124566
Test=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136470

[pkotwicz, 2012-05-10 05:15:00]

Adds GetImageSkiaNamed to resource_bundle and theme_provider

[Robert Sesek, 2012-05-10 12:28:35]

LGTM

http://codereview.chromium.org/10388064/diff/1/chrome/browser/ui/cocoa/bookma...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
(right):

http://codereview.chromium.org/10388064/diff/1/chrome/browser/ui/cocoa/bookma...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm:194:
virtual gfx::ImageSkia* GetImageSkiaNamed(int id) const { return nil; }
Return NULL for C++ objects

http://codereview.chromium.org/10388064/diff/1/chrome/browser/ui/cocoa/downlo...
File chrome/browser/ui/cocoa/download/background_theme.mm (right):

http://codereview.chromium.org/10388064/diff/1/chrome/browser/ui/cocoa/downlo...
chrome/browser/ui/cocoa/download/background_theme.mm:31: return nil;
Change both of these to NULL.

[sky, 2012-05-10 15:51:10]

http://codereview.chromium.org/10388064/diff/1/ui/base/resource/resource_bund...
File ui/base/resource/resource_bundle.cc (right):

http://codereview.chromium.org/10388064/diff/1/ui/base/resource/resource_bund...
ui/base/resource/resource_bundle.cc:217: return
const_cast<gfx::ImageSkia*>(image);
Why do we need this? Can't folks get the ImageSkia like this if they really need
it?

[sky, 2012-05-10 17:08:23]

LGTM

http://codereview.chromium.org/10388064/diff/1/chrome/browser/themes/theme_se...
File chrome/browser/themes/theme_service.cc (right):

http://codereview.chromium.org/10388064/diff/1/chrome/browser/themes/theme_se...
chrome/browser/themes/theme_service.cc:248: const gfx::Image* image =
GetImageNamed(id);
Add TODOs about removing casts.

http://codereview.chromium.org/10388064/diff/1/chrome/browser/ui/gtk/gtk_them...
File chrome/browser/ui/gtk/gtk_theme_service.cc (right):

http://codereview.chromium.org/10388064/diff/1/chrome/browser/ui/gtk/gtk_them...
chrome/browser/ui/gtk/gtk_theme_service.cc:305: return
const_cast<gfx::ImageSkia*>(GetImageNamed(id)->ToImageSkia());
TODO here too.

[commit-bot: I haz the power, 2012-05-10 21:27:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10388064/3002

[commit-bot: I haz the power, 2012-05-11 00:53:35]

Change committed as 136470