Issue 10388056: Fixes drag and drop crash. The problem was when I made

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388056: Fixes drag and drop crash. The problem was when I made (Closed)

Created:
8 years, 7 months ago by sky

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google), varunjain

CC:
chromium-reviews, tfarina, sadrul, dcheng, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes drag and drop crash. The problem was when I made MenuController::SetExitType do a QuitNow it would prematurely exit out of drag and drop, causing a crash. The fix is to not QuitNow if drag and drop is on going. (Have I mentioned I hate nested message loops?). I also changed DragDropController to QuitNow, this way tests can work and seems like what we want anyway. Lastly I made all the bookmarkbarviewtests work again as they provide coverage of this. BUG=127348 TEST=covered by tests R=ben@chromium.org,varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136365

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -50 lines)			Patch
M	ash/drag_drop/drag_drop_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/drag_drop/drag_drop_controller.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View	10 chunks	+43 lines, -39 lines	0 comments	Download
M	ui/views/controls/menu/menu_controller.h	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	ui/views/controls/menu/menu_controller.cc	View	4 chunks	+19 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

varunjain

8 years, 7 months ago (2012-05-10 17:07:28 UTC) #3

On 2012/05/10 14:38:03, Ben Goodger (Google) wrote:
> sadness. lgtm.

lgtm

Expand Messages | Collapse Messages