Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10388042: ninja windows: fix long command lines in more cases (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja windows: fix long command lines in more cases Discovered that: 1) the long command line test wasn't testing all the link command line (.lib and .dll weren't exercised), and 2) the standard executable test was right at the edge of the command line length limit, and so sometimes wouldn't fail. So, add tests for dll and lib, move more of the content of all the link lines into rsp files, and double the length of the command lines to be sure to hit the limit. R=thakis@chromium.org BUG=chromium:127290 Committed: https://code.google.com/p/gyp/source/detail?r=1373

Patch Set 1 #

Total comments: 1

Patch Set 2 : use * N #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -12 lines) Patch
M pylib/gyp/generator/ninja.py View 2 chunks +10 lines, -6 lines 0 comments Download
A test/win/long-command-line/function.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/win/long-command-line/long-command-line.gyp View 1 1 chunk +35 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
8 years, 7 months ago (2012-05-09 03:59:26 UTC) #1
Nico
https://chromiumcodereview.appspot.com/10388042/diff/1/test/win/long-command-line/long-command-line.gyp File test/win/long-command-line/long-command-line.gyp (right): https://chromiumcodereview.appspot.com/10388042/diff/1/test/win/long-command-line/long-command-line.gyp#newcode13 test/win/long-command-line/long-command-line.gyp:13: 'AdditionalOptions': '/nologo /nologo /nologo /nologo /nologo /nologo /nologo /nologo ...
8 years, 7 months ago (2012-05-09 04:00:40 UTC) #2
Nico
Other than that LGTM. (and if that doesn't work lgtm as is too)
8 years, 7 months ago (2012-05-09 04:05:30 UTC) #3
scottmg
8 years, 7 months ago (2012-05-09 04:08:22 UTC) #4 
On 2012/05/09 04:00:40, Nico wrote:

> Since this is basically a python file, does '/nologo ' * 1000 work?

Wow!!! That would have saved me a lot of typing!!! Or wait, do we get paid per
kloc?

(Yes, it does work. ;-)

Powered by Google App Engine
This is Rietveld 408576698