Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2800)

Unified Diff: pylib/gyp/generator/ninja.py

Issue 10388042: ninja windows: fix long command lines in more cases (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: use * N Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/win/long-command-line/function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py
index 575493b6b90b1a7b489bfe04690a98db8a102749..1a58b30a95ddf651e14446c67298cb21645ddd60 100644
--- a/pylib/gyp/generator/ninja.py
+++ b/pylib/gyp/generator/ninja.py
@@ -1340,18 +1340,20 @@ def GenerateOutputForConfig(target_list, target_dicts, data, params,
master_ninja.rule(
'alink',
description='LIB $out',
- command='$ar /nologo /ignore:4221 /OUT:$out @$out.rsp $libflags',
+ command='$ar /nologo /ignore:4221 /OUT:$out @$out.rsp',
rspfile='$out.rsp',
- rspfile_content='$in')
+ rspfile_content='$in $libflags')
dlldesc = 'LINK(DLL) $dll'
dllcmd = ('python gyp-win-tool link-wrapper '
'$ld /nologo /IMPLIB:$implib /DLL /OUT:$dll '
- '/PDB:$dll.pdb $libs @$dll.rsp $ldflags')
+ '/PDB:$dll.pdb @$dll.rsp')
master_ninja.rule('solink', description=dlldesc, command=dllcmd,
- rspfile='$dll.rsp', rspfile_content='$in',
+ rspfile='$dll.rsp',
+ rspfile_content='$libs $in $ldflags',
restat=True)
master_ninja.rule('solink_module', description=dlldesc, command=dllcmd,
- rspfile='$dll.rsp', rspfile_content='$in',
+ rspfile='$dll.rsp',
+ rspfile_content='$libs $in $ldflags',
restat=True)
# Note that ldflags goes at the end so that it has the option of
# overriding default settings earlier in the command line.
@@ -1359,7 +1361,9 @@ def GenerateOutputForConfig(target_list, target_dicts, data, params,
'link',
description='LINK $out',
command=('python gyp-win-tool link-wrapper '
- '$ld /nologo /OUT:$out /PDB:$out.pdb $in $libs $ldflags'))
+ '$ld /nologo /OUT:$out /PDB:$out.pdb @$out.rsp'),
+ rspfile='$out.rsp',
+ rspfile_content='$in $libs $ldflags')
else:
master_ninja.rule(
'objc',
« no previous file with comments | « no previous file | test/win/long-command-line/function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698