Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 10388023: AcceleratorController::AcceleratorPressed() should return true whenever some action is taken (Closed)

Created:
8 years, 7 months ago by Yusuke Sato
Modified:
8 years, 7 months ago
Reviewers:
mazda, Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, xiyuan
Visibility:
Public.

Description

AcceleratorController::AcceleratorPressed() should return true whenever some action is taken. Currently some actions do not follow the description of ui::AcceleratorTarget::AcceleratorPressed() in ui/base/accelerators/accelerator.h (see below). Though the violations don't cause any user visible issues at this moment, I believe they should be fixed. // Should return true if the accelerator was processed. virtual bool AcceleratorPressed(const Accelerator& accelerator) = 0; This change is also necessary for fixing 123856. BUG=123856 TEST=aura_shell_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136255

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 5 chunks +23 lines, -15 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yusuke Sato
8 years, 7 months ago (2012-05-08 06:02:16 UTC) #1
Daniel Erat
lgtm
8 years, 7 months ago (2012-05-08 13:52:22 UTC) #2
mazda
lgtm
8 years, 7 months ago (2012-05-08 22:32:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10388023/5001
8 years, 7 months ago (2012-05-10 06:23:43 UTC) #4
commit-bot: I haz the power
Try job failure for 10388023-5001 (retry) on mac_rel for step "browser_tests" (clobber build). It's a ...
8 years, 7 months ago (2012-05-10 07:05:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10388023/5001
8 years, 7 months ago (2012-05-10 07:09:35 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 07:27:23 UTC) #7
Try job failure for 10388023-5001 (retry) on android for steps "Compile, build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Powered by Google App Engine
This is Rietveld 408576698