DescriptionAcceleratorController::AcceleratorPressed() should return true whenever some action is taken.
Currently some actions do not follow the description of ui::AcceleratorTarget::AcceleratorPressed() in ui/base/accelerators/accelerator.h (see below). Though the violations don't cause any user visible issues at this moment, I believe they should be fixed.
// Should return true if the accelerator was processed.
virtual bool AcceleratorPressed(const Accelerator& accelerator) = 0;
This change is also necessary for fixing 123856.
BUG=123856
TEST=aura_shell_unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136255
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 7 (0 generated)
|