AcceleratorController::AcceleratorPressed() should return true whenever some action is taken

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include "ash/accelerators/accelerator_table.h"
 #include "ash/ash_switches.h"
 #include "ash/caps_lock_delegate.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 303 matching lines @@
       return true;
     case TAKE_PARTIAL_SCREENSHOT:
       if (screenshot_delegate_.get())
         ash::Shell::GetInstance()->delegate()->
             StartPartialScreenshot(screenshot_delegate_.get());
       // Return true to prevent propagation of the key event because
       // this key combination is reserved for partial screenshot.
       return true;
     case SEARCH_KEY:
       ash::Shell::GetInstance()->delegate()->Search();
-      break;
+      return true;
     case TOGGLE_APP_LIST:
       ash::Shell::GetInstance()->ToggleAppList();
-      break;
+      return true;
     case TOGGLE_CAPS_LOCK:
       if (caps_lock_delegate_.get())
         return caps_lock_delegate_->HandleToggleCapsLock();
       break;
     case BRIGHTNESS_DOWN:
       if (brightness_control_delegate_.get())
         return brightness_control_delegate_->HandleBrightnessDown(accelerator);
       break;
     case BRIGHTNESS_UP:
       if (brightness_control_delegate_.get())
@@ skipping 13 matching lines @@
       break;
     case FOCUS_LAUNCHER:
       if (shell->launcher())
         return shell->focus_cycler()->FocusWidget(shell->launcher()->widget());
       break;
     case FOCUS_TRAY:
       if (shell->tray())
         return shell->focus_cycler()->FocusWidget(shell->tray()->GetWidget());
       break;
     case SHOW_OAK:
-      if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshEnableOak))
+      if (CommandLine::ForCurrentProcess()->HasSwitch(
+              switches::kAshEnableOak)) {
         oak::ShowOakWindow();
+        return true;
+      }
       break;
     case NEXT_IME:
       if (ime_control_delegate_.get())
         return ime_control_delegate_->HandleNextIme();
       break;
     case PREVIOUS_IME:
       if (ime_control_delegate_.get())
         return ime_control_delegate_->HandlePreviousIme();
       break;
     case SWITCH_IME:
       if (ime_control_delegate_.get())
         return ime_control_delegate_->HandleSwitchIme(accelerator);
       break;
     case SELECT_WIN_0:
       SwitchToWindow(0);
-      break;
+      return true;
     case SELECT_WIN_1:
       SwitchToWindow(1);
-      break;
+      return true;
     case SELECT_WIN_2:
       SwitchToWindow(2);
-      break;
+      return true;
     case SELECT_WIN_3:
       SwitchToWindow(3);
-      break;
+      return true;
     case SELECT_WIN_4:
       SwitchToWindow(4);
-      break;
+      return true;
     case SELECT_WIN_5:
       SwitchToWindow(5);
-      break;
+      return true;
     case SELECT_WIN_6:
       SwitchToWindow(6);
-      break;
+      return true;
     case SELECT_WIN_7:
       SwitchToWindow(7);
-      break;
+      return true;
     case SELECT_LAST_WIN:
       SwitchToWindow(-1);
-      break;
+      return true;
     case WINDOW_SNAP_LEFT:
     case WINDOW_SNAP_RIGHT: {
       aura::Window* window = wm::GetActiveWindow();
       if (!window)
         break;
       internal::SnapSizer sizer(window,
           gfx::Point(),
           action == WINDOW_SNAP_LEFT ? internal::SnapSizer::LEFT_EDGE :
                                        internal::SnapSizer::RIGHT_EDGE,
           shell->GetGridSize());
       window->SetBounds(sizer.GetSnapBounds(window->bounds()));
-      break;
+      return true;
     }
     case WINDOW_MINIMIZE: {
       aura::Window* window = wm::GetActiveWindow();
-      if (window)
+      if (window) {
         wm::MinimizeWindow(window);
+        return true;
+      }
       break;
     }
     case WINDOW_MAXIMIZE_RESTORE: {
       aura::Window* window = wm::GetActiveWindow();
       if (window) {
         if (wm::IsWindowMaximized(window))
           wm::RestoreWindow(window);
         else
           wm::MaximizeWindow(window);
+        return true;
       }
       break;
     }
     case WINDOW_POSITION_CENTER: {
       aura::Window* window = wm::GetActiveWindow();
-      if (window)
+      if (window) {
         wm::CenterWindow(window);
+        return true;
+      }
       break;
     }
     case ROTATE_WINDOWS:
       return HandleRotateWindows();
 #if !defined(NDEBUG)
     case ROTATE_SCREEN:
       return HandleRotateScreen();
     case TOGGLE_DESKTOP_BACKGROUND_MODE:
       return HandleToggleDesktopBackgroundMode();
     case TOGGLE_ROOT_WINDOW_FULL_SCREEN:
@@ skipping 44 matching lines @@
     // Then set this one as active.
     Shell::GetInstance()->launcher()->ActivateLauncherItem(found_index);
   }
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash