Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 10388013: Move the Linux zygote stuff into its own per-process directory. (Closed)

Created:
8 years, 7 months ago by brettw
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move the Linux zygote stuff into its own per-process directory. The zygote is really a separate process and doesn't belong in the browser subdirectory. I separated out the common constants used for communication into content/[public/]/common so the zygote code doesn't depend on browser. This leaves zygote_main_linux alone in its own directory. I'm going to be doing some more refactoring and probably adding a new file or two here. This does not yet add a new build target for the zygot process. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135891

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -1074 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 3 chunks +15 lines, -11 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/zygote_host_impl_linux.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M content/browser/zygote_host_impl_linux.cc View 7 chunks +11 lines, -9 lines 0 comments Download
D content/browser/zygote_main_linux.cc View 1 chunk +0 lines, -1012 lines 0 comments Download
A content/common/zygote_commands_linux.h View 1 chunk +32 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/browser/zygote_host_linux.h View 1 chunk +2 lines, -11 lines 0 comments Download
A content/public/common/sandbox_linux.h View 1 chunk +27 lines, -0 lines 0 comments Download
A + content/zygote/zygote_main_linux.cc View 12 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
https://chromiumcodereview.appspot.com/10388013/diff/1/content/app/content_main_runner.cc File content/app/content_main_runner.cc (right): https://chromiumcodereview.appspot.com/10388013/diff/1/content/app/content_main_runner.cc#newcode83 content/app/content_main_runner.cc:83: namespace content { I added this function to the ...
8 years, 7 months ago (2012-05-07 20:25:59 UTC) #1
brettw
8 years, 7 months ago (2012-05-08 18:12:39 UTC) #2
Avi (use Gerrit)
lgtm
8 years, 7 months ago (2012-05-08 18:17:55 UTC) #3
brettw
TBR ben: chrome/ui, jam: content/app.
8 years, 7 months ago (2012-05-08 19:28:36 UTC) #4
Ben Goodger (Google)
8 years, 7 months ago (2012-05-08 19:30:14 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698