Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 10387230: add hangouts (Closed)

Created:
8 years, 7 months ago by sethladd
Modified:
8 years, 7 months ago
Reviewers:
Kathy Walrath, kathyw
Base URL:
https://code.google.com/p/dartlang-site/@master
Visibility:
Public.

Description

add hangouts BUG= TEST=

Patch Set 1 #

Total comments: 14

Patch Set 2 : tweaks from review #

Total comments: 1

Patch Set 3 : fix styles #

Patch Set 4 : tweaks from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -8 lines) Patch
M src/site/_includes/nav.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/site/css/style.css View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
A src/site/hangouts/dartisans-ep-2.markdown View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A src/site/hangouts/dartisans-ep-3.markdown View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A src/site/hangouts/dartisans-ep-4.markdown View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A src/site/hangouts/dartisans-ep-5.markdown View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A src/site/hangouts/index.markdown View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sethladd
staged at http://hangouts.dart-lang.appspot.com/hangouts/
8 years, 7 months ago (2012-05-22 04:48:05 UTC) #1
kathyw
Not sure about the format or titles... but it is nice to have the videos ...
8 years, 7 months ago (2012-05-22 15:46:34 UTC) #2
sethladd
please take another look. https://chromiumcodereview.appspot.com/10387230/diff/1/src/site/_includes/nav.html File src/site/_includes/nav.html (right): https://chromiumcodereview.appspot.com/10387230/diff/1/src/site/_includes/nav.html#newcode38 src/site/_includes/nav.html:38: {% nav_link /hangouts/ %}Hangouts{% endnav_link ...
8 years, 7 months ago (2012-05-22 17:28:47 UTC) #3
kathyw
Strike the "Ep." from each page's title, delete an apostrophe, and I think we're good ...
8 years, 7 months ago (2012-05-22 18:13:17 UTC) #4
kathyw
8 years, 7 months ago (2012-05-22 18:18:20 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698