Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 10387222: nss: revert encrypted and origin bound certificates support. (Closed)

Created:
8 years, 7 months ago by agl
Modified:
8 years, 3 months ago
Reviewers:
Visibility:
Public.

Description

nss: revert encrypted and origin bound certificates support. This change is the result of running patch -R to revert the two patches. A minor change is needed to ssl_client_socket_nss.cc in order for the result to compile. BUG=129174 TEST=none

Patch Set 1 #

Total comments: 2

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -885 lines) Patch
M net/socket/ssl_client_socket_nss.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M net/third_party/nss/README.chromium View 1 2 chunks +0 lines, -9 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +0 lines, -4 lines 0 comments Download
D net/third_party/nss/patches/encryptedclientcerts.patch View 1 chunk +0 lines, -390 lines 0 comments Download
D net/third_party/nss/patches/origin_bound_certs.patch View 1 chunk +0 lines, -219 lines 0 comments Download
M net/third_party/nss/ssl/ssl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 9 chunks +36 lines, -72 lines 0 comments Download
M net/third_party/nss/ssl/ssl3ext.c View 8 chunks +1 line, -147 lines 0 comments Download
M net/third_party/nss/ssl/sslimpl.h View 3 chunks +0 lines, -8 lines 0 comments Download
M net/third_party/nss/ssl/sslsock.c View 5 chunks +0 lines, -24 lines 0 comments Download
M net/third_party/nss/ssl/sslt.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
agl
8 years, 7 months ago (2012-05-21 21:08:07 UTC) #1
agl
8 years, 7 months ago (2012-05-21 21:09:59 UTC) #2
wtc
LGTM. https://chromiumcodereview.appspot.com/10387222/diff/1/net/third_party/nss/README.chromium File net/third_party/nss/README.chromium (left): https://chromiumcodereview.appspot.com/10387222/diff/1/net/third_party/nss/README.chromium#oldcode57 net/third_party/nss/README.chromium:57: https://bugzilla.mozilla.org/show_bug.cgi?id=691991 For future reference: the correct NSS bug ...
8 years, 7 months ago (2012-05-22 00:39:47 UTC) #3
wtc
agl: could you open a bug report for the Channel ID work and reference that ...
8 years, 7 months ago (2012-05-22 00:40:43 UTC) #4
agl
https://chromiumcodereview.appspot.com/10387222/diff/1/net/third_party/nss/README.chromium File net/third_party/nss/README.chromium (left): https://chromiumcodereview.appspot.com/10387222/diff/1/net/third_party/nss/README.chromium#oldcode57 net/third_party/nss/README.chromium:57: https://bugzilla.mozilla.org/show_bug.cgi?id=691991 On 2012/05/22 00:39:47, wtc wrote: > > For ...
8 years, 7 months ago (2012-05-22 15:13:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10387222/1012
8 years, 7 months ago (2012-05-22 15:16:05 UTC) #6
commit-bot: I haz the power
Try job failure for 10387222-1012 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 15:43:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10387222/1012
8 years, 7 months ago (2012-05-22 16:17:55 UTC) #8
commit-bot: I haz the power
Try job failure for 10387222-1012 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 17:38:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10387222/1012
8 years, 7 months ago (2012-05-22 17:42:06 UTC) #10
commit-bot: I haz the power
Try job failure for 10387222-1012 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 19:24:40 UTC) #11
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 14:56:47 UTC) #12
No reviewers yet.

Powered by Google App Engine
This is Rietveld 408576698