src/ia32/debug-ia32.cc - Issue 10387116: Fix issue 825 (LiveEdit vs. function with no locals) for x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/debug-ia32.cc

Issue 10387116: Fix issue 825 (LiveEdit vs. function with no locals) for x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: follow codereview Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/debug-ia32.cc

diff --git a/src/ia32/debug-ia32.cc b/src/ia32/debug-ia32.cc

index 901e38bfe3e33a855270d5ed107549a780291073..d153e18ee9ad24439766438954944cad296d7b9f 100644

--- a/src/ia32/debug-ia32.cc

+++ b/src/ia32/debug-ia32.cc

@@ -175,7 +175,7 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

// Read current padding counter and skip corresponding number of words.

__ pop(unused_reg);

// We divide stored value by 2 (untagging) and multiply it by word's size.

- STATIC_ASSERT(kSmiTagSize == 1);

+ STATIC_ASSERT(kSmiTagSize == 1 && kSmiShiftSize == 0);

__ lea(esp, Operand(esp, unused_reg, times_half_pointer_size, 0));

// Get rid of the internal frame.

« no previous file with comments | « no previous file | src/x64/debug-x64.cc » ('j') | no next file with comments »