Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 10387116: Fix issue 825 (LiveEdit vs. function with no locals) for x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: follow codereview Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/debug-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 if (!taken) { 168 if (!taken) {
169 unused_reg = reg; 169 unused_reg = reg;
170 } 170 }
171 } 171 }
172 172
173 ASSERT(unused_reg.code() != -1); 173 ASSERT(unused_reg.code() != -1);
174 174
175 // Read current padding counter and skip corresponding number of words. 175 // Read current padding counter and skip corresponding number of words.
176 __ pop(unused_reg); 176 __ pop(unused_reg);
177 // We divide stored value by 2 (untagging) and multiply it by word's size. 177 // We divide stored value by 2 (untagging) and multiply it by word's size.
178 STATIC_ASSERT(kSmiTagSize == 1); 178 STATIC_ASSERT(kSmiTagSize == 1 && kSmiShiftSize == 0);
179 __ lea(esp, Operand(esp, unused_reg, times_half_pointer_size, 0)); 179 __ lea(esp, Operand(esp, unused_reg, times_half_pointer_size, 0));
180 180
181 // Get rid of the internal frame. 181 // Get rid of the internal frame.
182 } 182 }
183 183
184 // If this call did not replace a call but patched other code then there will 184 // If this call did not replace a call but patched other code then there will
185 // be an unwanted return address left on the stack. Here we get rid of that. 185 // be an unwanted return address left on the stack. Here we get rid of that.
186 if (convert_call_to_jmp) { 186 if (convert_call_to_jmp) {
187 __ add(esp, Immediate(kPointerSize)); 187 __ add(esp, Immediate(kPointerSize));
188 } 188 }
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 353
354 const bool Debug::kFrameDropperSupported = true; 354 const bool Debug::kFrameDropperSupported = true;
355 355
356 #undef __ 356 #undef __
357 357
358 #endif // ENABLE_DEBUGGER_SUPPORT 358 #endif // ENABLE_DEBUGGER_SUPPORT
359 359
360 } } // namespace v8::internal 360 } } // namespace v8::internal
361 361
362 #endif // V8_TARGET_ARCH_IA32 362 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/x64/debug-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698