Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: tools/isolate/isolate_smoke_test.py

Issue 10386211: An empty .results file would throw ValueError, eat it. (Closed) Base URL: bombe.local:src/chrome/src@11_fix_handling_gypv8sh
Patch Set: Update integration test Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/isolate.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/isolate_smoke_test.py
diff --git a/tools/isolate/isolate_smoke_test.py b/tools/isolate/isolate_smoke_test.py
index 02ad18c32bcf129c8697a785e329d2ee2d3b752c..a11d17f5f3cabc5270a8d97c6fd307bad794aee9 100755
--- a/tools/isolate/isolate_smoke_test.py
+++ b/tools/isolate/isolate_smoke_test.py
@@ -478,7 +478,11 @@ class Isolate_trace(IsolateBase):
# Includes spew from tracerpt.exe.
self.assertTrue(out.startswith(expected))
else:
- self.assertEquals(expected, out.rstrip())
+ lines = out.strip().splitlines()
+ self.assertEquals(3, len(lines))
+ self.assertTrue(lines[0].startswith('WARNING'))
+ self.assertTrue(lines[1].startswith('WARNING'))
+ self.assertEquals(expected, lines[2])
def test_missing_trailing_slash(self):
try:
« no previous file with comments | « tools/isolate/isolate.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698