tools/isolate/isolate.py - Issue 10386211: An empty .results file would throw ValueError, eat it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/isolate/isolate.py

Issue 10386211: An empty .results file would throw ValueError, eat it. (Closed) Base URL: bombe.local:src/chrome/src@11_fix_handling_gypv8sh

Patch Set: Update integration test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/isolate/isolate.py

diff --git a/tools/isolate/isolate.py b/tools/isolate/isolate.py

index 47ca000115263ea4096e951823aff51b312ebb46..252ca0ccb13657f38f71a7625611d94588a651ae 100755

--- a/tools/isolate/isolate.py

+++ b/tools/isolate/isolate.py

@@ -298,8 +298,8 @@ class Flattenable(object):

with open(filename, 'r') as f:

out = cls.load(json.load(f))

logging.debug('Loaded %s(%s)' % (cls.__name__, filename))

- except IOError:

- pass

+ except (IOError, ValueError):

+ logging.warn('Failed to load %s' % filename)

return out

« no previous file with comments | « no previous file | tools/isolate/isolate_smoke_test.py » ('j') | no next file with comments »