Issue 10386211: An empty .results file would throw ValueError, eat it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386211: An empty .results file would throw ValueError, eat it. (Closed)

Created:
8 years, 7 months ago by M-A Ruel

Modified:
8 years, 7 months ago

Reviewers:
MAD

CC:
chromium-reviews, csharp

Base URL:
bombe.local:src/chrome/src@11_fix_handling_gypv8sh

Visibility:
Public.

More Reviews

Description

An empty .results file would throw ValueError, eat it. R=mad@chromium.org BUG= TEST=Switching from test_isolate_mode=noop to hashtable works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137910

Patch Set 2 : add log output #

Patch Set 3 : Update integration test #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	tools/isolate/isolate.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tools/isolate/isolate_smoke_test.py	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

MAD

LGTM with a potential nit... https://chromiumcodereview.appspot.com/10386211/diff/1/tools/isolate/isolate.py File tools/isolate/isolate.py (right): https://chromiumcodereview.appspot.com/10386211/diff/1/tools/isolate/isolate.py#newcode301 tools/isolate/isolate.py:301: except (IOError, ValueError): Shouldn't ...

8 years, 7 months ago (2012-05-18 17:46:03 UTC) #2

M-A Ruel

8 years, 7 months ago (2012-05-18 17:51:01 UTC) #3

https://chromiumcodereview.appspot.com/10386211/diff/1/tools/isolate/isolate.py
File tools/isolate/isolate.py (right):

https://chromiumcodereview.appspot.com/10386211/diff/1/tools/isolate/isolate....
tools/isolate/isolate.py:301: except (IOError, ValueError):
On 2012/05/18 17:46:03, MAD wrote:
> Shouldn't you at lease log these?

done