ppapi/thunk/ppb_graphics_3d_thunk.cc - Issue 10386145: Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/thunk/ppb_graphics_3d_thunk.cc

Issue 10386145: Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments; remove createOffscreenGraphicsContext3D Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/proxy/resource_creation_proxy.h ('K') | « ppapi/proxy/resource_creation_proxy.cc ('k') | ppapi/thunk/ppb_graphics_3d_trusted_thunk.cc » ('j') | ppapi/thunk/ppb_graphics_3d_trusted_thunk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/thunk/ppb_graphics_3d_thunk.cc

diff --git a/ppapi/thunk/ppb_graphics_3d_thunk.cc b/ppapi/thunk/ppb_graphics_3d_thunk.cc

index edc19caae07710c4c1750b14269850496f0a42de..b75b587bb15e153055d3c858d2494a3d8d419dc0 100644

--- a/ppapi/thunk/ppb_graphics_3d_thunk.cc

+++ b/ppapi/thunk/ppb_graphics_3d_thunk.cc

@@ -27,10 +27,11 @@ PP_Resource Create(PP_Instance instance,

PP_Resource share_context,

const int32_t attrib_list[]) {

EnterResourceCreation enter(instance);

- if (enter.failed())

+ EnterGraphics3D enter_share(share_context, true);

piman 2012/05/16 23:38:45 This should be EnterResourceNoLock, since the lock

(scshunt) 2012/05/17 16:55:45 Ah ok.

+ if (enter.failed() || enter_share.failed())

return 0;

return enter.functions()->CreateGraphics3D(

- instance, share_context, attrib_list);

+ instance, enter_share.object(), attrib_list);

}

PP_Bool IsGraphics3D(PP_Resource resource) {