Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

ppapi/thunk/ppb_graphics_3d_thunk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/thunk/enter.h"
 #include "ppapi/thunk/thunk.h"
 #include "ppapi/thunk/ppb_graphics_3d_api.h"
 #include "ppapi/thunk/resource_creation_api.h"
 
 namespace ppapi {
 namespace thunk {
 
 namespace {
 
 typedef EnterResource<PPB_Graphics3D_API> EnterGraphics3D;
 
 int32_t GetAttribMaxValue(PP_Instance instance,
                           int32_t attribute,
                           int32_t* value) {
   // TODO(alokp): Implement me.
   return PP_ERROR_FAILED;
 }
 
 PP_Resource Create(PP_Instance instance,
                    PP_Resource share_context,
                    const int32_t attrib_list[]) {
   EnterResourceCreation enter(instance);
-  if (enter.failed())
+  EnterGraphics3D enter_share(share_context, true);

[piman, 2012/05/16 23:38:45]

This should be EnterResourceNoLock, since the lock was already taken by the
EnterResourceCreation.

[(scshunt), 2012/05/17 16:55:45]

Ah ok.

+  if (enter.failed() || enter_share.failed())
     return 0;
   return enter.functions()->CreateGraphics3D(
-      instance, share_context, attrib_list);
+      instance, enter_share.object(), attrib_list);
 }
 
 PP_Bool IsGraphics3D(PP_Resource resource) {
   EnterGraphics3D enter(resource, false);
   return PP_FromBool(enter.succeeded());
 }
 
 int32_t GetAttribs(PP_Resource graphics_3d, int32_t attrib_list[]) {
   EnterGraphics3D enter(graphics_3d, true);
   if (enter.failed())
@@ skipping 41 matching lines @@
 };
 
 }  // namespace
 
 const PPB_Graphics3D_1_0* GetPPB_Graphics3D_1_0_Thunk() {
   return &g_ppb_graphics_3d_thunk;
 }
 
 }  // namespace thunk
 }  // namespace ppapi