Get Swarm Bots to Use Network Storage

Get Swarm Bots to Use Network Storage

Setup the slave to store their output (needed by the swarm bots) on a network drive so that a single server on swarm master machine can serve all the data needed by the swarm bots.

R=maruel@chromium.org
BUG=98834
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136630

[M-A Ruel, 2012-05-11 15:35:32]

lgtm with nits

https://chromiumcodereview.appspot.com/10386096/diff/1/masters/master.chromiu...
File masters/master.chromium.swarm/master.cfg (right):

https://chromiumcodereview.appspot.com/10386096/diff/1/masters/master.chromiu...
masters/master.chromium.swarm/master.cfg:119: '\\\\fas2-110\\swarm-data',
Eventually, this will need to be a variable in site_config but this is fine for
now.

https://chromiumcodereview.appspot.com/10386096/diff/1/scripts/slave/run_slav...
File scripts/slave/run_slavelastic.py (right):

https://chromiumcodereview.appspot.com/10386096/diff/1/scripts/slave/run_slav...
scripts/slave/run_slavelastic.py:208: options.data_url = 'http://%s/' %
socket.gethostbyname(socket.gethostname())
you could use default= instead.

https://chromiumcodereview.appspot.com/10386096/diff/1/scripts/slave/unittest...
File scripts/slave/unittests/run_slavelastic_test.py (right):

https://chromiumcodereview.appspot.com/10386096/diff/1/scripts/slave/unittest...
scripts/slave/unittests/run_slavelastic_test.py:22: class Switches(object):
Options would be a strictly better name but I don't mind.

https://chromiumcodereview.appspot.com/10386096/diff/1/scripts/slave/unittest...
scripts/slave/unittests/run_slavelastic_test.py:37: 'win32': 'Windows',
sort the list?

https://chromiumcodereview.appspot.com/10386096/diff/1/scripts/slave/unittest...
scripts/slave/unittests/run_slavelastic_test.py:41: }
-2

[csharp, 2012-05-11 19:16:41]

http://codereview.chromium.org/10386096/diff/1/masters/master.chromium.swarm/...
File masters/master.chromium.swarm/master.cfg (right):

http://codereview.chromium.org/10386096/diff/1/masters/master.chromium.swarm/...
masters/master.chromium.swarm/master.cfg:119: '\\\\fas2-110\\swarm-data',
On 2012/05/11 15:35:32, Marc-Antoine Ruel wrote:
> Eventually, this will need to be a variable in site_config but this is fine
for
> now.

Added a note.

http://codereview.chromium.org/10386096/diff/1/scripts/slave/run_slavelastic.py
File scripts/slave/run_slavelastic.py (right):

http://codereview.chromium.org/10386096/diff/1/scripts/slave/run_slavelastic....
scripts/slave/run_slavelastic.py:208: options.data_url = 'http://%s/' %
socket.gethostbyname(socket.gethostname())
On 2012/05/11 15:35:32, Marc-Antoine Ruel wrote:
> you could use default= instead.

Done.

http://codereview.chromium.org/10386096/diff/1/scripts/slave/unittests/run_sl...
File scripts/slave/unittests/run_slavelastic_test.py (right):

http://codereview.chromium.org/10386096/diff/1/scripts/slave/unittests/run_sl...
scripts/slave/unittests/run_slavelastic_test.py:22: class Switches(object):
On 2012/05/11 15:35:32, Marc-Antoine Ruel wrote:
> Options would be a strictly better name but I don't mind.

Done.

http://codereview.chromium.org/10386096/diff/1/scripts/slave/unittests/run_sl...
scripts/slave/unittests/run_slavelastic_test.py:37: 'win32': 'Windows',
On 2012/05/11 15:35:32, Marc-Antoine Ruel wrote:
> sort the list?

Done.

http://codereview.chromium.org/10386096/diff/1/scripts/slave/unittests/run_sl...
scripts/slave/unittests/run_slavelastic_test.py:41: }
On 2012/05/11 15:35:32, Marc-Antoine Ruel wrote:
> -2

Done.

[commit-bot: I haz the power, 2012-05-11 19:16:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/10386096/6001

[commit-bot: I haz the power, 2012-05-11 19:19:44]

Change committed as 136630