Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 10386096: Get Swarm Bots to Use Network Storage (Closed)

Created:
8 years, 7 months ago by csharp
Modified:
8 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Get Swarm Bots to Use Network Storage Setup the slave to store their output (needed by the swarm bots) on a network drive so that a single server on swarm master machine can serve all the data needed by the swarm bots. R=maruel@chromium.org BUG=98834 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136630

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -111 lines) Patch
M masters/master.chromium.swarm/master.cfg View 1 5 chunks +7 lines, -1 line 0 comments Download
M scripts/master/factory/swarm_commands.py View 2 chunks +5 lines, -2 lines 0 comments Download
M scripts/master/factory/swarm_factory.py View 3 chunks +18 lines, -1 line 0 comments Download
M scripts/slave/run_slavelastic.py View 1 10 chunks +38 lines, -33 lines 0 comments Download
M scripts/slave/unittests/run_slavelastic_test.py View 1 3 chunks +69 lines, -74 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csharp
8 years, 7 months ago (2012-05-11 15:21:15 UTC) #1
M-A Ruel
lgtm with nits https://chromiumcodereview.appspot.com/10386096/diff/1/masters/master.chromium.swarm/master.cfg File masters/master.chromium.swarm/master.cfg (right): https://chromiumcodereview.appspot.com/10386096/diff/1/masters/master.chromium.swarm/master.cfg#newcode119 masters/master.chromium.swarm/master.cfg:119: '\\\\fas2-110\\swarm-data', Eventually, this will need to ...
8 years, 7 months ago (2012-05-11 15:35:32 UTC) #2
csharp
http://codereview.chromium.org/10386096/diff/1/masters/master.chromium.swarm/master.cfg File masters/master.chromium.swarm/master.cfg (right): http://codereview.chromium.org/10386096/diff/1/masters/master.chromium.swarm/master.cfg#newcode119 masters/master.chromium.swarm/master.cfg:119: '\\\\fas2-110\\swarm-data', On 2012/05/11 15:35:32, Marc-Antoine Ruel wrote: > Eventually, ...
8 years, 7 months ago (2012-05-11 19:16:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10386096/6001
8 years, 7 months ago (2012-05-11 19:16:57 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 19:19:44 UTC) #5
Change committed as 136630

Powered by Google App Engine
This is Rietveld 408576698