Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 10384178: ash: Make sure all the sub-popups retain the same height as the main popup. (Closed)

Created:
8 years, 7 months ago by sadrul
Modified:
8 years, 7 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Make sure all the sub-popups retain the same height as the main popup. This required a few smaller changes: * Refactor some code for creating the detailed view. * Change the layout code for the new layout in the mocks. * Add a way for re-using an existing bubble instead of creating a new one. BUG=127430 TEST=aura_shell_unittests.BubbleCreationTypesTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137149

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -157 lines) Patch
M ash/ash.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/bluetooth/tray_bluetooth.cc View 7 chunks +9 lines, -29 lines 0 comments Download
M ash/system/drive/tray_drive.cc View 7 chunks +10 lines, -23 lines 0 comments Download
M ash/system/ime/tray_ime.cc View 6 chunks +9 lines, -22 lines 0 comments Download
M ash/system/network/tray_network.cc View 11 chunks +14 lines, -40 lines 0 comments Download
M ash/system/tray/system_tray.h View 3 chunks +11 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +17 lines, -12 lines 0 comments Download
M ash/system/tray/system_tray_bubble.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 5 chunks +39 lines, -19 lines 0 comments Download
M ash/system/tray/system_tray_item.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_item.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 5 chunks +41 lines, -6 lines 0 comments Download
A ash/system/tray/tray_details_view.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A ash/system/tray/tray_details_view.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download
M ash/system/tray/tray_item_more.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
.
8 years, 7 months ago (2012-05-15 04:49:17 UTC) #1
sadrul
.
8 years, 7 months ago (2012-05-15 05:29:27 UTC) #2
sadrul
8 years, 7 months ago (2012-05-15 05:30:37 UTC) #3
Ben Goodger (Google)
8 years, 7 months ago (2012-05-15 16:07:28 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698