ash: Make sure all the sub-popups retain the same height as the main popup.

ash/system/network/tray_network.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/network/tray_network.h"
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/tray_constants.h"
+#include "ash/system/tray/tray_details_view.h"
 #include "ash/system/tray/tray_item_more.h"
 #include "ash/system/tray/tray_item_view.h"
 #include "ash/system/tray/tray_views.h"
 #include "base/utf_string_conversions.h"
 #include "grit/ash_strings.h"
 #include "grit/ui_resources.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/aura/window.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
@@ skipping 121 matching lines @@
         GetMostRelevantNetworkIcon(&info, true);
     SetImage(&info.image);
     SetLabel(info.description);
     SetAccessibleName(info.description);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(NetworkDefaultView);
 };
 
-class NetworkDetailedView : public views::View,
+class NetworkDetailedView : public TrayDetailsView,
                             public views::ButtonListener,
                             public ViewClickListener {
  public:
   explicit NetworkDetailedView(user::LoginStatus login)
       : login_(login),
-        header_(NULL),
         airplane_(NULL),
         info_icon_(NULL),
         button_wifi_(NULL),
         button_cellular_(NULL),
         view_mobile_account_(NULL),
         setup_mobile_account_(NULL),
-        networks_list_(NULL),
-        scroller_(NULL),
         other_wifi_(NULL),
         other_mobile_(NULL),
         settings_(NULL),
         proxy_settings_(NULL),
         info_bubble_(NULL) {
-    SetLayoutManager(new views::BoxLayout(
-        views::BoxLayout::kVertical, 0, 0, 0));
-    set_background(views::Background::CreateSolidBackground(kBackgroundColor));
     SystemTrayDelegate* delegate = Shell::GetInstance()->tray_delegate();
     delegate->RequestNetworkScan();
     CreateItems();
     Update();
   }
 
   virtual ~NetworkDetailedView() {
     if (info_bubble_)
       info_bubble_->GetWidget()->CloseNow();
   }
 
   void CreateItems() {
     RemoveAllChildViews(true);
 
-    header_ = NULL;
     airplane_ = NULL;
     info_icon_ = NULL;
     button_wifi_ = NULL;
     button_cellular_ = NULL;
     view_mobile_account_ = NULL;
     setup_mobile_account_ = NULL;
-    networks_list_ = NULL;
-    scroller_ = NULL;
     other_wifi_ = NULL;
     other_mobile_ = NULL;
     settings_ = NULL;
     proxy_settings_ = NULL;
 
     AppendNetworkEntries();
     AppendNetworkExtra();
     AppendHeaderEntry();
     AppendHeaderButtons();
 
     Update();
   }
 
   void Update() {
     UpdateHeaderButtons();
     UpdateNetworkEntries();
     UpdateNetworkExtra();
 
     Layout();
   }
 
  private:
   void AppendHeaderEntry() {
-    header_ = new SpecialPopupRow();
-    header_->SetTextLabel(IDS_ASH_STATUS_TRAY_NETWORK, this);
-    AddChildView(header_);
+    CreateSpecialRow(IDS_ASH_STATUS_TRAY_NETWORK, this);
   }
 
   void AppendHeaderButtons() {
     button_wifi_ = new TrayPopupHeaderButton(this,
         IDR_AURA_UBER_TRAY_WIFI_ENABLED,
         IDR_AURA_UBER_TRAY_WIFI_DISABLED,
         IDR_AURA_UBER_TRAY_WIFI_ENABLED_HOVER,
         IDR_AURA_UBER_TRAY_WIFI_DISABLED_HOVER);
-    header_->AddButton(button_wifi_);
+    footer()->AddButton(button_wifi_);
 
     button_cellular_ = new TrayPopupHeaderButton(this,
         IDR_AURA_UBER_TRAY_CELLULAR_ENABLED,
         IDR_AURA_UBER_TRAY_CELLULAR_DISABLED,
         IDR_AURA_UBER_TRAY_CELLULAR_ENABLED_HOVER,
         IDR_AURA_UBER_TRAY_CELLULAR_DISABLED_HOVER);
-    header_->AddButton(button_cellular_);
+    footer()->AddButton(button_cellular_);
 
     info_icon_ = new TrayPopupHeaderButton(this,
         IDR_AURA_UBER_TRAY_NETWORK_INFO,
         IDR_AURA_UBER_TRAY_NETWORK_INFO,
         IDR_AURA_UBER_TRAY_NETWORK_INFO_HOVER,
         IDR_AURA_UBER_TRAY_NETWORK_INFO_HOVER);
-    header_->AddButton(info_icon_);
+    footer()->AddButton(info_icon_);
   }
 
   void UpdateHeaderButtons() {
     SystemTrayDelegate* delegate = Shell::GetInstance()->tray_delegate();
     button_wifi_->SetToggled(!delegate->GetWifiEnabled());
     button_cellular_->SetToggled(!delegate->GetCellularEnabled());
     button_cellular_->SetVisible(delegate->GetCellularAvailable());
   }
 
   void AppendNetworkEntries() {
-    FixedSizedScrollView* scroller = new FixedSizedScrollView;
-    networks_list_ = new views::View;
-    networks_list_->SetLayoutManager(new views::BoxLayout(
-        views::BoxLayout::kVertical, 0, 0, 1));
+    CreateScrollableList();
 
     HoverHighlightView* container = new HoverHighlightView(this);
     container->set_fixed_height(kTrayPopupItemHeight);
     container->AddLabel(ui::ResourceBundle::GetSharedInstance().
         GetLocalizedString(IDS_ASH_STATUS_TRAY_MOBILE_VIEW_ACCOUNT),
         gfx::Font::NORMAL);
     AddChildView(container);
     view_mobile_account_ = container;
 
     container = new HoverHighlightView(this);
     container->set_fixed_height(kTrayPopupItemHeight);
     container->AddLabel(ui::ResourceBundle::GetSharedInstance().
         GetLocalizedString(IDS_ASH_STATUS_TRAY_SETUP_MOBILE),
         gfx::Font::NORMAL);
     AddChildView(container);
     setup_mobile_account_ = container;
-
-    scroller->set_border(views::Border::CreateSolidSidedBorder(1, 0, 1, 0,
-        SkColorSetARGB(25, 0, 0, 0)));
-    scroller->set_fixed_size(
-        gfx::Size(networks_list_->GetPreferredSize().width() +
-                  scroller->GetScrollBarWidth(),
-                  kNetworkListHeight));
-    scroller->SetContentsView(networks_list_);
-    AddChildView(scroller);
-    scroller_ = scroller;
   }
 
   void UpdateNetworkEntries() {
     SystemTrayDelegate* delegate = Shell::GetInstance()->tray_delegate();
     std::vector<NetworkIconInfo> list;
     delegate->GetAvailableNetworks(&list);
 
     network_map_.clear();
-    networks_list_->RemoveAllChildViews(true);
+    scroll_content()->RemoveAllChildViews(true);
     views::View* highlighted_view = NULL;
     for (size_t i = 0; i < list.size(); i++) {
       HoverHighlightView* container = new HoverHighlightView(this);
       container->set_fixed_height(kTrayPopupItemHeight);
       container->AddIconAndLabel(list[i].image,
           list[i].description.empty() ? list[i].name : list[i].description,
           list[i].highlight ? gfx::Font::BOLD : gfx::Font::NORMAL);
-      networks_list_->AddChildView(container);
+      scroll_content()->AddChildView(container);
       if (list[i].highlight)
         highlighted_view = container;
       container->set_border(views::Border::CreateEmptyBorder(0,
           kTrayPopupDetailsIconWidth, 0, 0));
       network_map_[container] = list[i].service_path;
     }
-    networks_list_->SizeToPreferredSize();
-    scroller_->Layout();
+    scroll_content()->SizeToPreferredSize();
+    static_cast<views::View*>(scroller())->Layout();
     if (highlighted_view)
-      networks_list_->ScrollRectToVisible(highlighted_view->bounds());
+      scroll_content()->ScrollRectToVisible(highlighted_view->bounds());
 
     view_mobile_account_->SetVisible(false);
     setup_mobile_account_->SetVisible(false);
 
     if (login_ == user::LOGGED_IN_NONE)
       return;
 
     std::string carrier_id, topup_url, setup_url;
     if (delegate->GetCellularCarrierInfo(&carrier_id,
                                          &topup_url,
@@ skipping 159 matching lines @@
   }
 
   // Overridden from ViewClickListener.
   virtual void ClickedOn(views::View* sender) OVERRIDE {
     ash::SystemTrayDelegate* delegate =
         ash::Shell::GetInstance()->tray_delegate();
     // If the info bubble was visible, close it when some other item is clicked
     // on.
     ResetInfoBubble();
 
-    if (sender == header_->content())
-      Shell::GetInstance()->tray()->ShowDefaultView();
+    if (sender == footer()->content())
+      Shell::GetInstance()->tray()->ShowDefaultView(BUBBLE_USE_EXISTING);
 
     if (login_ == user::LOGGED_IN_LOCKED)
       return;
 
     if (sender == view_mobile_account_) {
       delegate->ShowCellularURL(topup_url_);
     } else if (sender == setup_mobile_account_) {
       delegate->ShowCellularURL(setup_url_);
     } else if (sender == airplane_) {
       delegate->ToggleAirplaneMode();
     } else {
       std::map<views::View*, std::string>::iterator find;
       find = network_map_.find(sender);
       if (find != network_map_.end()) {
         std::string network_id = find->second;
         delegate->ConnectToNetwork(network_id);
       }
     }
   }
 
   std::string carrier_id_;
   std::string topup_url_;
   std::string setup_url_;
 
   user::LoginStatus login_;
   std::map<views::View*, std::string> network_map_;
-  SpecialPopupRow* header_;
   views::View* airplane_;
   TrayPopupHeaderButton* info_icon_;
   TrayPopupHeaderButton* button_wifi_;
   TrayPopupHeaderButton* button_cellular_;
   views::View* view_mobile_account_;
   views::View* setup_mobile_account_;
-  views::View* networks_list_;
-  views::View* scroller_;
   TrayPopupTextButton* other_wifi_;
   TrayPopupTextButton* other_mobile_;
   TrayPopupTextButton* settings_;
   TrayPopupTextButton* proxy_settings_;
 
   views::BubbleDelegateView* info_bubble_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkDetailedView);
 };
 
@@ skipping 45 matching lines @@
   if (tray_)
     tray_->Update(info);
   if (default_)
     default_->Update();
   if (detailed_)
     detailed_->Update();
 }
 
 }  // namespace internal
 }  // namespace ash