Issue 10384155: [filemanager] Content metadata moved to the cache.

Issue 10384155: [filemanager] Content metadata moved to the cache. (Closed)

Created:
8 years, 7 months ago by dgozman

Modified:
8 years, 7 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[filemanager] Content metadata moved to the cache. Metadata usage in gallery is not touched yet. This change includes metadata eviction. Also localized one metadata string value. BUG=129347 TEST=Nothing changed for user. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138465

Patch Set 1 #

Patch Set 2 : Handling content metadata for not-present gdata files. #

Total comments: 6

Patch Set 3 : Moved MetadataProvider from file_manager.js to gallery.js #

Patch Set 4 : Merged with ToT #

Patch Set 5 : More usage in comments #

Patch Set 6 : Bug #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+420 lines, -135 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/gallery.html	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2 3	15 chunks	+76 lines, -83 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_type.js	View	1 2 3	1 chunk	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View	1 2 3	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery_scripts.js	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/main_scripts.js	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/audio_player.js	View	1 2 3	6 chunks	+16 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/mediaplayer_scripts.js	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/metadata_cache.js	View	1 2 3 4	16 chunks	+311 lines, -19 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/metadata_provider.js	View	1 2 3	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/mediaplayer.html	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

https://chromiumcodereview.appspot.com/10384155/diff/4001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js (right): https://chromiumcodereview.appspot.com/10384155/diff/4001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode431 chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:431: Math.round(MetadataCache.EVICTION_NUMBER / 2); This computations needs a comment https://chromiumcodereview.appspot.com/10384155/diff/4001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode763 ...

8 years, 7 months ago (2012-05-16 12:46:27 UTC) #2

dgozman

PTAL https://chromiumcodereview.appspot.com/10384155/diff/4001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js (right): https://chromiumcodereview.appspot.com/10384155/diff/4001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode431 chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:431: Math.round(MetadataCache.EVICTION_NUMBER / 2); On 2012/05/16 12:46:28, Vladislav Kaznacheev ...

8 years, 7 months ago (2012-05-16 15:12:11 UTC) #3

satorux1

this is a refactoring work, right? then, please don't submit this until we are done ...

8 years, 7 months ago (2012-05-17 16:22:28 UTC) #5

dgozman

8 years, 7 months ago (2012-05-18 11:36:44 UTC) #6

Yes, I'm waiting a bit.

On Thu, May 17, 2012 at 8:22 PM, <satorux@chromium.org> wrote:

> this is a refactoring work, right? then, please don't submit this until we
> are
> done with m20 issues, not to make merging difficult. Josh will announce
> once we
> are done with m20 issues.
>
> sorry for the inconvenience but we are close to get there...
>
>
https://chromiumcodereview.**appspot.com/10384155/<https://chromiumcodereview...
>

Expand Messages | Collapse Messages