Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: chrome/browser/resources/file_manager/js/file_type.js

Issue 10384155: [filemanager] Content metadata moved to the cache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Bug Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_type.js
===================================================================
--- chrome/browser/resources/file_manager/js/file_type.js (revision 138459)
+++ chrome/browser/resources/file_manager/js/file_type.js (working copy)
@@ -239,14 +239,12 @@
* the image itself as a thumbnail. If the image is too large it hurts
* the performance very much so we allow it only for moderately sized files.
*
- * @param {Object} metadata From MetadataProvider.
- * @param {number} opt_size The file size to be used if the metadata does not
- * contain fileSize.
+ * @param {number} width Image width.
+ * @param {number} height Image height.
+ * @param {number} fileSize The file size.
* @return {boolean} Whether it is OK to use the image url for a preview.
*/
-FileType.canUseImageUrlForPreview = function(metadata, opt_size) {
- var fileSize = metadata.fileSize || opt_size;
- return ((fileSize && fileSize <= FileType.MAX_PREVIEW_FILE_SIZE) ||
- (metadata.width && metadata.height &&
- (metadata.width * metadata.height <= FileType.MAX_PREVIEW_PIXEL_COUNT)));
+FileType.canUseImageUrlForPreview = function(width, height, fileSize) {
+ return (fileSize && fileSize <= FileType.MAX_PREVIEW_FILE_SIZE) ||
+ (width && height && width * height <= FileType.MAX_PREVIEW_PIXEL_COUNT);
};

Powered by Google App Engine
This is Rietveld 408576698