When converting -m/--message to -t, make sure to handle the case --message=foo

When converting -m/--message to -t, make sure to handle the case --message=foo
correctly.  Also fix git_cl.py.

BUG=None
TEST=Make sure that the -m command line option to gcl upload/git cl upload
does not add a new message to the rietveld issue.  The string associated to the
--message argument should only be used as the patchset title.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136922

[M-A Ruel, 2012-05-14 14:17:38]

https://chromiumcodereview.appspot.com/10384150/diff/1/gcl.py
File gcl.py (right):

https://chromiumcodereview.appspot.com/10384150/diff/1/gcl.py#newcode831
gcl.py:831: if a == '-m':
Note that

gcl upload foo -mbleh
works.

https://chromiumcodereview.appspot.com/10384150/diff/1/gcl.py#newcode836
gcl.py:836: args = map(replace_message, args)
What about printing out a warning message when one of the condition triggers?
print 'Warning, you must start using -t instead of -m. -m will post a message
unconditionally.'
or
'See FAQ at <url>'
or whatever so devs can learn on the go.

[Roger Tawa OOO till Jul 10th, 2012-05-14 16:09:50]

Salut MA, please take another look.  I also fixed git_cl.py.

http://codereview.chromium.org/10384150/diff/1/gcl.py
File gcl.py (right):

http://codereview.chromium.org/10384150/diff/1/gcl.py#newcode831
gcl.py:831: if a == '-m':
On 2012/05/14 14:17:39, Marc-Antoine Ruel wrote:
> Note that
> 
> gcl upload foo -mbleh
> works.

Didn't know that, fixed.

http://codereview.chromium.org/10384150/diff/1/gcl.py#newcode836
gcl.py:836: args = map(replace_message, args)
On 2012/05/14 14:17:39, Marc-Antoine Ruel wrote:
> What about printing out a warning message when one of the condition triggers?
> print 'Warning, you must start using -t instead of -m. -m will post a message
> unconditionally.'
> or
> 'See FAQ at <url>'
> or whatever so devs can learn on the go.

Yes, good idea. Done.

[M-A Ruel, 2012-05-14 16:13:24]

http://codereview.chromium.org/10384150/diff/4001/gcl.py
File gcl.py (right):

http://codereview.chromium.org/10384150/diff/4001/gcl.py#newcode842
gcl.py:842: '\nWARNING: Use -t or --title to set the title of the patchset.\n' +
no need for +

http://codereview.chromium.org/10384150/diff/4001/gcl.py#newcode844
gcl.py:844: 'See
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...
for details.\n')
Maybe make a http://goo.gl url?

http://codereview.chromium.org/10384150/diff/4001/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/10384150/diff/4001/git_cl.py#newcode1046
git_cl.py:1046: parser.add_option('-m', dest='message', help='message for
patch')
You forgot to add -t :)

[Roger Tawa OOO till Jul 10th, 2012-05-14 18:17:02]

Salut MA,

Sent the last patchset a little too early for review.  Should be good now,
please take another look.  Thanks.

http://codereview.chromium.org/10384150/diff/4001/gcl.py
File gcl.py (right):

http://codereview.chromium.org/10384150/diff/4001/gcl.py#newcode842
gcl.py:842: '\nWARNING: Use -t or --title to set the title of the patchset.\n' +
On 2012/05/14 16:13:24, Marc-Antoine Ruel wrote:
> no need for +

Done.

http://codereview.chromium.org/10384150/diff/4001/gcl.py#newcode844
gcl.py:844: 'See
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...
for details.\n')
On 2012/05/14 16:13:24, Marc-Antoine Ruel wrote:
> Maybe make a http://goo.gl url?

Done.

http://codereview.chromium.org/10384150/diff/4001/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/10384150/diff/4001/git_cl.py#newcode1046
git_cl.py:1046: parser.add_option('-m', dest='message', help='message for
patch')
On 2012/05/14 16:13:24, Marc-Antoine Ruel wrote:
> You forgot to add -t :)

Duh.  This file was far from done before sending for review.  Sorry.

[M-A Ruel, 2012-05-14 18:20:50]

lgtm

http://codereview.chromium.org/10384150/diff/6002/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/10384150/diff/6002/git_cl.py#newcode1054
git_cl.py:1054: parser.add_option('-t', dest='title', help='title for patch')
s/patch/patchset/ ?

[Roger Tawa OOO till Jul 10th, 2012-05-14 18:33:08]

Thanks MA,

http://codereview.chromium.org/10384150/diff/6002/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/10384150/diff/6002/git_cl.py#newcode1054
git_cl.py:1054: parser.add_option('-t', dest='title', help='title for patch')
On 2012/05/14 18:20:50, Marc-Antoine Ruel wrote:
> s/patch/patchset/ ?

Done.

[commit-bot: I haz the power, 2012-05-14 18:33:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/10384150/8003

[commit-bot: I haz the power, 2012-05-14 18:41:40]

Change committed as 136922