When converting -m/--message to -t, make sure to handle the case --message=foo

gcl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 807 matching lines @@
   output = OptionallyDoPresubmitChecks(change_info, False, args)
   if not output.should_continue():
     return 1
   no_watchlists = (FilterFlag(args, "--no_watchlists") or
                    FilterFlag(args, "--no-watchlists"))
 
   # Map --send-mail to --send_mail
   if FilterFlag(args, "--send-mail"):
     args.append("--send_mail")
 
-  # Replace -m or --message with -t.
-  args = map(lambda a: '-t' if (a == '-m' or a == '--message') else a, args)
-  
+  # Replace -m with -t.  Replace --message with --title, but make sure to
+  # preserve anything after the --message.
+  def replace_message(a):
+    if a == '-m':

[M-A Ruel, 2012/05/14 14:17:39]

Note that

gcl upload foo -mbleh
works.

[Roger Tawa OOO till Jul 10th, 2012/05/14 16:09:50]

Didn't know that, fixed.

+      return '-t'
+    elif a.startswith('--message'):
+      return '--title' + a[9:]
+    return a
+  args = map(replace_message, args)

[M-A Ruel, 2012/05/14 14:17:39]

What about printing out a warning message when one of the condition triggers?
print 'Warning, you must start using -t instead of -m. -m will post a message
unconditionally.'
or
'See FAQ at <url>'
or whatever so devs can learn on the go.

[Roger Tawa OOO till Jul 10th, 2012/05/14 16:09:50]

Yes, good idea. Done.

 
   upload_arg = ["upload.py", "-y"]
   upload_arg.append("--server=%s" % change_info.rietveld)
 
   reviewers = change_info.reviewers or output.reviewers
   if (reviewers and
       not any(arg.startswith('-r') or arg.startswith('--reviewer') for
               arg in args)):
     upload_arg.append('--reviewers=%s' % ','.join(reviewers))
 
@@ skipping 600 matching lines @@
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))