Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10384025: fix duplicated basename network_change_notifier.cc in net target (Closed)

Created:
8 years, 7 months ago by Wei James(wistoch)
Modified:
8 years, 7 months ago
Reviewers:
Yaron, Nico, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

fix duplicated basename network_change_notifier.cc in net target BUG=126356 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -94 lines) Patch
M net/android/net_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/android/network_change_notifier.h View 1 chunk +0 lines, -41 lines 0 comments Download
D net/android/network_change_notifier.cc View 1 chunk +0 lines, -49 lines 0 comments Download
A + net/android/network_change_notifier_android.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/android/network_change_notifier_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/network_change_notifier_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Yaron
lgtm Sorry, I didn't see this before. When you upload a CL for review, you ...
8 years, 7 months ago (2012-05-08 21:23:48 UTC) #1
Ryan Sleevi
lgtm
8 years, 7 months ago (2012-05-08 21:31:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10384025/1
8 years, 7 months ago (2012-05-08 21:34:14 UTC) #3
commit-bot: I haz the power
Try job failure for 10384025-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-09 01:01:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10384025/1
8 years, 7 months ago (2012-05-09 01:05:22 UTC) #5
commit-bot: I haz the power
Try job failure for 10384025-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=27263 Step "update" is always ...
8 years, 7 months ago (2012-05-09 01:27:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10384025/1
8 years, 7 months ago (2012-05-09 05:10:11 UTC) #7
commit-bot: I haz the power
Try job failure for 10384025-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=27418 Step "update" is always ...
8 years, 7 months ago (2012-05-09 05:23:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10384025/1
8 years, 7 months ago (2012-05-09 05:28:34 UTC) #9
commit-bot: I haz the power
Try job failure for 10384025-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-09 08:37:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10384025/1
8 years, 7 months ago (2012-05-09 14:08:50 UTC) #11
commit-bot: I haz the power
Try job failure for 10384025-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-09 16:55:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10384025/1
8 years, 7 months ago (2012-05-09 23:25:02 UTC) #13
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 01:05:30 UTC) #14 
Change committed as 136207

Powered by Google App Engine
This is Rietveld 408576698