Issue 10383292: Get rid of the need of ViewType::VIEW_TYPE_INTERSTITIAL_PAGE in content. There are no ViewType valu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383292: Get rid of the need of ViewType::VIEW_TYPE_INTERSTITIAL_PAGE in content. There are no ViewType valu… (Closed)

Created:
8 years, 7 months ago by jam

Modified:
8 years, 7 months ago

Reviewers:
Avi (use Gerrit), jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get rid of the need of ViewType::VIEW_TYPE_INTERSTITIAL_PAGE in content. There are no ViewType values left in content, so in the next change I'll move this whole concept out of content and into chrome. That allows us to get rid of RenderViewHostDelegate::GetRenderViewType which is the last remaining need for RVHD in chrome. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138369

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -8 lines)			Patch
M	chrome/browser/content_settings/tab_specific_content_settings.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/content_settings/tab_specific_content_settings.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_view_host_observer.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/web_contents/interstitial_page_impl.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/public/browser/interstitial_page.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/web_contents_observer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages