Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 10383292: Get rid of the need of ViewType::VIEW_TYPE_INTERSTITIAL_PAGE in content. There are no ViewType valu… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/interstitial_page.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
===================================================================
--- content/public/browser/web_contents_observer.h (revision 138257)
+++ content/public/browser/web_contents_observer.h (working copy)
@@ -27,7 +27,11 @@
class CONTENT_EXPORT WebContentsObserver : public IPC::Channel::Listener,
public IPC::Message::Sender {
public:
+ // Only one of the two methods below will be called when a RVH is created for
+ // a WebContents, depending on whether it's for an interstitial or not.
virtual void RenderViewCreated(RenderViewHost* render_view_host) {}
+ virtual void RenderViewForInterstitialPageCreated(
+ RenderViewHost* render_view_host) {}
virtual void RenderViewDeleted(RenderViewHost* render_view_host) {}
virtual void RenderViewReady() {}
virtual void RenderViewGone(base::TerminationStatus status) {}
« no previous file with comments | « content/public/browser/interstitial_page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698