Issue 10383282: Fixing mistake in the mapping of manifest settings from vcbuild to msbuild.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383282: Fixing mistake in the mapping of manifest settings from vcbuild to msbuild. (Closed)

Created:
8 years, 7 months ago by bradn

Modified:
8 years, 7 months ago

Reviewers:
pkotwicz1, robertshield, scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Fixing mistake in the mapping of manifest settings from vcbuild to msbuild. Mt should have been Manifest. Perils of tests that recaptiulate the implementation. BUG=http://code.google.com/p/gyp/issues/detail?id=222 TEST=None R=scottmg@chromium.org,pkotwicz@google.com,robertshield@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1391

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	pylib/gyp/MSVSSettings.py	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	pylib/gyp/MSVSSettings_test.py	View	1 2	6 chunks	+9 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

scottmg

Test doesn't seem much improved. :) But lgtm to get dev channel fixed.

8 years, 7 months ago (2012-05-22 18:19:40 UTC) #2

lgtm