Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: pylib/gyp/MSVSSettings_test.py

Issue 10383282: Fixing mistake in the mapping of manifest settings from vcbuild to msbuild. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pylib/gyp/MSVSSettings.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2011 Google Inc. All rights reserved. 3 # Copyright (c) 2012 Google Inc. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Unit tests for the MSVSSettings.py file.""" 7 """Unit tests for the MSVSSettings.py file."""
8 8
9 import StringIO 9 import StringIO
10 import unittest 10 import unittest
11 import gyp.MSVSSettings as MSVSSettings 11 import gyp.MSVSSettings as MSVSSettings
12 12
13 13
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 'Name': 'a_file_name', 507 'Name': 'a_file_name',
508 'OutputFile': 'a_file_name', 508 'OutputFile': 'a_file_name',
509 'RemoveObjects': 'file1;file2', 509 'RemoveObjects': 'file1;file2',
510 'SubSystem': 'Console', 510 'SubSystem': 'Console',
511 'SuppressStartupBanner': 'true', 511 'SuppressStartupBanner': 'true',
512 'TargetMachine': 'MachineX86i', 512 'TargetMachine': 'MachineX86i',
513 'TrackerLogDirectory': 'a_folder', 513 'TrackerLogDirectory': 'a_folder',
514 'TreatLibWarningAsErrors': 'true', 514 'TreatLibWarningAsErrors': 'true',
515 'UseUnicodeResponseFiles': 'true', 515 'UseUnicodeResponseFiles': 'true',
516 'Verbose': 'true'}, 516 'Verbose': 'true'},
517 'Mt': { 517 'Manifest': {
518 'AdditionalManifestFiles': 'file1;file2', 518 'AdditionalManifestFiles': 'file1;file2',
519 'AdditionalOptions': 'a string1', 519 'AdditionalOptions': 'a string1',
520 'AssemblyIdentity': 'a string1', 520 'AssemblyIdentity': 'a string1',
521 'ComponentFileName': 'a_file_name', 521 'ComponentFileName': 'a_file_name',
522 'EnableDPIAwareness': 'fal', 522 'EnableDPIAwareness': 'fal',
523 'GenerateCatalogFiles': 'truel', 523 'GenerateCatalogFiles': 'truel',
524 'GenerateCategoryTags': 'true', 524 'GenerateCategoryTags': 'true',
525 'InputResourceManifests': 'a string1', 525 'InputResourceManifests': 'a string1',
526 'ManifestFromManagedAssembly': 'a_file_name', 526 'ManifestFromManagedAssembly': 'a_file_name',
527 'notgood3': 'bogus', 527 'notgood3': 'bogus',
(...skipping 15 matching lines...) Expand all
543 'ResourceOutputFileName': 'a_file_name'}, 543 'ResourceOutputFileName': 'a_file_name'},
544 '': { 544 '': {
545 'EmbedManifest': 'true', 545 'EmbedManifest': 'true',
546 'GenerateManifest': 'true', 546 'GenerateManifest': 'true',
547 'IgnoreImportLibrary': 'true', 547 'IgnoreImportLibrary': 'true',
548 'LinkIncremental': 'false'}}, 548 'LinkIncremental': 'false'}},
549 self.stderr) 549 self.stderr)
550 self._ExpectedWarnings([ 550 self._ExpectedWarnings([
551 'Warning: unrecognized setting ClCompile/Enableprefast', 551 'Warning: unrecognized setting ClCompile/Enableprefast',
552 'Warning: unrecognized setting ClCompile/ZZXYZ', 552 'Warning: unrecognized setting ClCompile/ZZXYZ',
553 'Warning: unrecognized setting Mt/notgood3', 553 'Warning: unrecognized setting Manifest/notgood3',
554 "Warning: for Mt/GenerateCatalogFiles, expected bool; got 'truel'", 554 'Warning: for Manifest/GenerateCatalogFiles, '
555 "expected bool; got 'truel'",
555 'Warning: for Lib/TargetMachine, unrecognized enumerated value ' 556 'Warning: for Lib/TargetMachine, unrecognized enumerated value '
556 'MachineX86i', 557 'MachineX86i',
557 "Warning: for Mt/EnableDPIAwareness, expected bool; got 'fal'"]) 558 "Warning: for Manifest/EnableDPIAwareness, expected bool; got 'fal'"])
558 559
559 def testConvertToMSBuildSettings_empty(self): 560 def testConvertToMSBuildSettings_empty(self):
560 """Tests an empty conversion.""" 561 """Tests an empty conversion."""
561 msvs_settings = {} 562 msvs_settings = {}
562 expected_msbuild_settings = {} 563 expected_msbuild_settings = {}
563 actual_msbuild_settings = MSVSSettings.ConvertToMSBuildSettings( 564 actual_msbuild_settings = MSVSSettings.ConvertToMSBuildSettings(
564 msvs_settings, 565 msvs_settings,
565 self.stderr) 566 self.stderr)
566 self.assertEqual(expected_msbuild_settings, actual_msbuild_settings) 567 self.assertEqual(expected_msbuild_settings, actual_msbuild_settings)
567 self._ExpectedWarnings([]) 568 self._ExpectedWarnings([])
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
1047 'AdditionalLibraryDirectories': 'folder1;folder2;folder3', 1048 'AdditionalLibraryDirectories': 'folder1;folder2;folder3',
1048 'AdditionalOptions': 'a_string', 1049 'AdditionalOptions': 'a_string',
1049 'ExportNamedFunctions': 'd1;d2;d3', 1050 'ExportNamedFunctions': 'd1;d2;d3',
1050 'ForceSymbolReferences': 'a_string', 1051 'ForceSymbolReferences': 'a_string',
1051 'IgnoreAllDefaultLibraries': 'true', 1052 'IgnoreAllDefaultLibraries': 'true',
1052 'IgnoreSpecificDefaultLibraries': 'file1;file2;file3', 1053 'IgnoreSpecificDefaultLibraries': 'file1;file2;file3',
1053 'ModuleDefinitionFile': 'a_file_name', 1054 'ModuleDefinitionFile': 'a_file_name',
1054 'OutputFile': 'a_file_name', 1055 'OutputFile': 'a_file_name',
1055 'SuppressStartupBanner': 'true', 1056 'SuppressStartupBanner': 'true',
1056 'UseUnicodeResponseFiles': 'true'}, 1057 'UseUnicodeResponseFiles': 'true'},
1057 'Mt': { 1058 'Manifest': {
1058 'AdditionalManifestFiles': 'file1;file2;file3', 1059 'AdditionalManifestFiles': 'file1;file2;file3',
1059 'AdditionalOptions': 'a_string', 1060 'AdditionalOptions': 'a_string',
1060 'AssemblyIdentity': 'a_string', 1061 'AssemblyIdentity': 'a_string',
1061 'ComponentFileName': 'a_file_name', 1062 'ComponentFileName': 'a_file_name',
1062 'GenerateCatalogFiles': 'true', 1063 'GenerateCatalogFiles': 'true',
1063 'InputResourceManifests': 'a_string', 1064 'InputResourceManifests': 'a_string',
1064 'OutputManifestFile': 'a_file_name', 1065 'OutputManifestFile': 'a_file_name',
1065 'RegistrarScriptFile': 'a_file_name', 1066 'RegistrarScriptFile': 'a_file_name',
1066 'ReplacementsFile': 'a_file_name', 1067 'ReplacementsFile': 'a_file_name',
1067 'SuppressStartupBanner': 'true', 1068 'SuppressStartupBanner': 'true',
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
1117 AssemblyLinkResource: ';%(AssemblyLinkResource)', 1118 AssemblyLinkResource: ';%(AssemblyLinkResource)',
1118 DelayLoadDLLs: ';%(DelayLoadDLLs)', 1119 DelayLoadDLLs: ';%(DelayLoadDLLs)',
1119 EmbedManagedResourceFile: ';%(EmbedManagedResourceFile)', 1120 EmbedManagedResourceFile: ';%(EmbedManagedResourceFile)',
1120 ForceSymbolReferences: ';%(ForceSymbolReferences)', 1121 ForceSymbolReferences: ';%(ForceSymbolReferences)',
1121 IgnoreSpecificDefaultLibraries: 1122 IgnoreSpecificDefaultLibraries:
1122 ';%(IgnoreSpecificDefaultLibraries)', 1123 ';%(IgnoreSpecificDefaultLibraries)',
1123 ResourceCompile: 1124 ResourceCompile:
1124 AdditionalIncludeDirectories: ';%(AdditionalIncludeDirectories)', 1125 AdditionalIncludeDirectories: ';%(AdditionalIncludeDirectories)',
1125 AdditionalOptions: ' %(AdditionalOptions)', 1126 AdditionalOptions: ' %(AdditionalOptions)',
1126 PreprocessorDefinitions: ';%(PreprocessorDefinitions)', 1127 PreprocessorDefinitions: ';%(PreprocessorDefinitions)',
1127 Mt: 1128 Manifest:
1128 AdditionalManifestFiles: ';%(AdditionalManifestFiles)', 1129 AdditionalManifestFiles: ';%(AdditionalManifestFiles)',
1129 AdditionalOptions: ' %(AdditionalOptions)', 1130 AdditionalOptions: ' %(AdditionalOptions)',
1130 InputResourceManifests: ';%(InputResourceManifests)', 1131 InputResourceManifests: ';%(InputResourceManifests)',
1131 """ 1132 """
1132 msvs_settings = { 1133 msvs_settings = {
1133 'VCCLCompilerTool': { 1134 'VCCLCompilerTool': {
1134 'AdditionalIncludeDirectories': 'dir1', 1135 'AdditionalIncludeDirectories': 'dir1',
1135 'AdditionalOptions': '/more', 1136 'AdditionalOptions': '/more',
1136 'AdditionalUsingDirectories': 'test', 1137 'AdditionalUsingDirectories': 'test',
1137 'AssemblerListingLocation': '$(IntDir)\\a', 1138 'AssemblerListingLocation': '$(IntDir)\\a',
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
1435 'UACUIAccess': 'true', 1436 'UACUIAccess': 'true',
1436 'Version': '333'}, 1437 'Version': '333'},
1437 'ResourceCompile': { 1438 'ResourceCompile': {
1438 'AdditionalIncludeDirectories': 'f3', 1439 'AdditionalIncludeDirectories': 'f3',
1439 'AdditionalOptions': '/more3', 1440 'AdditionalOptions': '/more3',
1440 'Culture': '0x0c0c', 1441 'Culture': '0x0c0c',
1441 'IgnoreStandardIncludePath': 'true', 1442 'IgnoreStandardIncludePath': 'true',
1442 'PreprocessorDefinitions': '_UNICODE;UNICODE2', 1443 'PreprocessorDefinitions': '_UNICODE;UNICODE2',
1443 'ResourceOutputFileName': '$(IntDir)%(Filename)3.res', 1444 'ResourceOutputFileName': '$(IntDir)%(Filename)3.res',
1444 'ShowProgress': 'true'}, 1445 'ShowProgress': 'true'},
1445 'Mt': { 1446 'Manifest': {
1446 'AdditionalManifestFiles': 'sfsdfsd', 1447 'AdditionalManifestFiles': 'sfsdfsd',
1447 'AdditionalOptions': 'afdsdafsd', 1448 'AdditionalOptions': 'afdsdafsd',
1448 'AssemblyIdentity': 'sddfdsadfsa', 1449 'AssemblyIdentity': 'sddfdsadfsa',
1449 'ComponentFileName': 'fsdfds', 1450 'ComponentFileName': 'fsdfds',
1450 'GenerateCatalogFiles': 'true', 1451 'GenerateCatalogFiles': 'true',
1451 'InputResourceManifests': 'asfsfdafs', 1452 'InputResourceManifests': 'asfsfdafs',
1452 'OutputManifestFile': '$(TargetPath).manifestdfs', 1453 'OutputManifestFile': '$(TargetPath).manifestdfs',
1453 'RegistrarScriptFile': 'sdfsfd', 1454 'RegistrarScriptFile': 'sdfsfd',
1454 'ReplacementsFile': 'sdffsd', 1455 'ReplacementsFile': 'sdffsd',
1455 'SuppressStartupBanner': 'false', 1456 'SuppressStartupBanner': 'false',
(...skipping 16 matching lines...) Expand all
1472 } 1473 }
1473 actual_msbuild_settings = MSVSSettings.ConvertToMSBuildSettings( 1474 actual_msbuild_settings = MSVSSettings.ConvertToMSBuildSettings(
1474 msvs_settings, 1475 msvs_settings,
1475 self.stderr) 1476 self.stderr)
1476 self.assertEqual(expected_msbuild_settings, actual_msbuild_settings) 1477 self.assertEqual(expected_msbuild_settings, actual_msbuild_settings)
1477 self._ExpectedWarnings([]) 1478 self._ExpectedWarnings([])
1478 1479
1479 1480
1480 if __name__ == '__main__': 1481 if __name__ == '__main__':
1481 unittest.main() 1482 unittest.main()
OLDNEW
« no previous file with comments | « pylib/gyp/MSVSSettings.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698