Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 10383280: Remove unnecessary code for non-zero-length global regexps. (Closed)

Created:
8 years, 7 months ago by Yang
Modified:
8 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Remove unnecessary code for non-zero-length global regexps. Also fixing a bug in the arm implementation. BUG= TEST=regexp-global.js Committed: https://code.google.com/p/v8/source/detail?r=11704

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -46 lines) Patch
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +17 lines, -13 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 2 chunks +17 lines, -14 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +7 lines, -3 lines 2 comments Download
src/regexp-macro-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 2 chunks +17 lines, -14 lines 0 comments Download
M test/mjsunit/regexp-global.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
PTAL.
8 years, 7 months ago (2012-05-22 15:34:22 UTC) #1
Yang
On 2012/05/22 15:34:22, Yang wrote: > PTAL. Ping.
8 years, 6 months ago (2012-06-04 07:39:24 UTC) #2
Erik Corry
8 years, 6 months ago (2012-06-04 08:00:11 UTC) #3
LGTM

https://chromiumcodereview.appspot.com/10383280/diff/1/src/regexp-macro-assem...
File src/regexp-macro-assembler.h (right):

https://chromiumcodereview.appspot.com/10383280/diff/1/src/regexp-macro-assem...
src/regexp-macro-assembler.h:187: enum GlobalFlag { NOT_GLOBAL, GLOBAL,
GLOBAL_NO_ZERO_LENGTH_MATCH };
I think GlobalMode would be better than GlobalFlag now that there are three
states.  And GLOBAL_NO_ZERO_LENGTH_CHECK better expresses what the macro
assembler has to do (perform the check for zero length matches).

https://chromiumcodereview.appspot.com/10383280/diff/1/src/regexp-macro-assem...
src/regexp-macro-assembler.h:192: inline bool global_with_zero_length_match() {
global_with_zero_length_check()

Powered by Google App Engine
This is Rietveld 408576698