Remove unnecessary code for non-zero-length global regexps.

src/regexp-macro-assembler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 166 matching lines @@
   // Return whether the matching (with a global regexp) will be restarted.
   virtual bool Succeed() = 0;
   virtual void WriteCurrentPositionToRegister(int reg, int cp_offset) = 0;
   virtual void ClearRegisters(int reg_from, int reg_to) = 0;
   virtual void WriteStackPointerToRegister(int reg) = 0;
 
   // Controls the generation of large inlined constants in the code.
   void set_slow_safe(bool ssc) { slow_safe_compiler_ = ssc; }
   bool slow_safe() { return slow_safe_compiler_; }
 
+  enum GlobalFlag { NOT_GLOBAL, GLOBAL, GLOBAL_NO_ZERO_LENGTH_MATCH };

[Erik Corry, 2012/06/04 08:00:11]

I think GlobalMode would be better than GlobalFlag now that there are three
states.  And GLOBAL_NO_ZERO_LENGTH_CHECK better expresses what the macro
assembler has to do (perform the check for zero length matches).

   // Set whether the regular expression has the global flag.  Exiting due to
   // a failure in a global regexp may still mean success overall.
-  void set_global(bool global) { global_ = global; }
-  bool global() { return global_; }
+  inline void set_global_flag(GlobalFlag flag) { global_flag_ = flag; }
+  inline bool global() { return global_flag_ != NOT_GLOBAL; }
+  inline bool global_with_zero_length_match() {

[Erik Corry, 2012/06/04 08:00:11]

global_with_zero_length_check()

+    return global_flag_ == GLOBAL;
+  }
 
  private:
   bool slow_safe_compiler_;
-  bool global_;
+  bool global_flag_;
 };
 
 
 #ifndef V8_INTERPRETED_REGEXP  // Avoid compiling unused code.
 
 class NativeRegExpMacroAssembler: public RegExpMacroAssembler {
  public:
   // Type of input string to generate code for.
   enum Mode { ASCII = 1, UC16 = 2 };
 
@@ skipping 53 matching lines @@
                         int* output,
                         int output_size,
                         Isolate* isolate);
 };
 
 #endif  // V8_INTERPRETED_REGEXP
 
 } }  // namespace v8::internal
 
 #endif  // V8_REGEXP_MACRO_ASSEMBLER_H_