Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5921)

Unified Diff: chrome/common/net/gaia/gaia_oauth_client.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/important_file_writer.h ('k') | chrome/common/net/gaia/oauth2_access_token_consumer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/gaia/gaia_oauth_client.h
diff --git a/chrome/common/net/gaia/gaia_oauth_client.h b/chrome/common/net/gaia/gaia_oauth_client.h
index 6a132acd20d2a47f125eba6f5b2579d2238eef21..e5156aff34d95c8f0b7c6ad691733306155a786f 100644
--- a/chrome/common/net/gaia/gaia_oauth_client.h
+++ b/chrome/common/net/gaia/gaia_oauth_client.h
@@ -30,8 +30,6 @@ class GaiaOAuthClient {
public:
class Delegate {
public:
- virtual ~Delegate() { }
-
// Invoked on a successful response to the GetTokensFromAuthCode request.
virtual void OnGetTokensResponse(const std::string& refresh_token,
const std::string& access_token,
@@ -45,6 +43,9 @@ class GaiaOAuthClient {
// response. This is invoked when the maximum number of retries have been
// exhausted. If max_retries is -1, this is never invoked.
virtual void OnNetworkError(int response_code) = 0;
+
+ protected:
+ virtual ~Delegate() {}
};
GaiaOAuthClient(const std::string& gaia_url,
net::URLRequestContextGetter* context_getter);
« no previous file with comments | « chrome/common/important_file_writer.h ('k') | chrome/common/net/gaia/oauth2_access_token_consumer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698