Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5138)

Unified Diff: chrome/common/important_file_writer.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | chrome/common/net/gaia/gaia_oauth_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/important_file_writer.h
diff --git a/chrome/common/important_file_writer.h b/chrome/common/important_file_writer.h
index 6209faf36dd854476e2d00cf64ec9fe2497cd588..25b558bae24af3d6e9f8f6b77a9dda7e403489f7 100644
--- a/chrome/common/important_file_writer.h
+++ b/chrome/common/important_file_writer.h
@@ -42,12 +42,13 @@ class ImportantFileWriter : public base::NonThreadSafe {
// to also batch data serializations.
class DataSerializer {
public:
- virtual ~DataSerializer() {}
-
// Should put serialized string in |data| and return true on successful
// serialization. Will be called on the same thread on which
// ImportantFileWriter has been created.
virtual bool SerializeData(std::string* data) = 0;
+
+ protected:
+ virtual ~DataSerializer() {}
};
// Initialize the writer.
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | chrome/common/net/gaia/gaia_oauth_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698