Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/cancelable_request.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/base_bookmark_model_observer.h ('k') | chrome/browser/cancelable_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cancelable_request.h
diff --git a/chrome/browser/cancelable_request.h b/chrome/browser/cancelable_request.h
index 3ab893c4d4e4782298e703bf9c0c1cd2a9fd852f..69939ede6e39704a17985c7bde9139aa8d3f29d9 100644
--- a/chrome/browser/cancelable_request.h
+++ b/chrome/browser/cancelable_request.h
@@ -122,7 +122,6 @@ class CancelableRequestProvider {
typedef int Handle;
CancelableRequestProvider();
- virtual ~CancelableRequestProvider();
// Called by the enduser of the request to cancel it. This MUST be called on
// the same thread that originally issued the request (which is also the same
@@ -131,6 +130,8 @@ class CancelableRequestProvider {
void CancelRequest(Handle handle);
protected:
+ virtual ~CancelableRequestProvider();
+
// Adds a new request and initializes it. This is called by a derived class
// to add a new request. The request's Init() will be called (which is why
// the consumer is required. The handle to the new request is returned.
« no previous file with comments | « chrome/browser/bookmarks/base_bookmark_model_observer.h ('k') | chrome/browser/cancelable_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698