Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: chrome/browser/bookmarks/base_bookmark_model_observer.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cancelable_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/base_bookmark_model_observer.h
diff --git a/chrome/browser/bookmarks/base_bookmark_model_observer.h b/chrome/browser/bookmarks/base_bookmark_model_observer.h
index 6c01483afdeaba8fbe0780e879d27bdd395efc34..f40ddea605f77b404a43314eee769f68c016b2b0 100644
--- a/chrome/browser/bookmarks/base_bookmark_model_observer.h
+++ b/chrome/browser/bookmarks/base_bookmark_model_observer.h
@@ -15,7 +15,6 @@
class BaseBookmarkModelObserver : public BookmarkModelObserver {
public:
BaseBookmarkModelObserver() {}
- virtual ~BaseBookmarkModelObserver() {}
virtual void BookmarkModelChanged() = 0;
@@ -41,6 +40,9 @@ class BaseBookmarkModelObserver : public BookmarkModelObserver {
virtual void BookmarkNodeChildrenReordered(BookmarkModel* model,
const BookmarkNode* node) OVERRIDE;
+ protected:
+ virtual ~BaseBookmarkModelObserver() {}
+
private:
DISALLOW_COPY_AND_ASSIGN(BaseBookmarkModelObserver);
};
« no previous file with comments | « no previous file | chrome/browser/cancelable_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698