Replaced EXPECT_TRUE with a LOG(WARNING) for automation commands to provide more information...

Replaced EXPECT_TRUE with a LOG(WARNING) for automation commands to provide more information about the failure.

Also reports the amount of time the automation call took, which should give some idea whether it returned due to a timeout.

BUG=chromium-os:30880
TEST=Compiled and ran a PyAuto test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137570

[dennis_jeffrey, 2012-05-16 19:03:38]

LGTM.  Please wait for Nirnimesh to approve before submitting.

[Nirnimesh, 2012-05-16 19:55:17]

https://chromiumcodereview.appspot.com/10383216/diff/2001/chrome/test/pyautol...
File chrome/test/pyautolib/pyautolib.cc (right):

https://chromiumcodereview.appspot.com/10383216/diff/2001/chrome/test/pyautol...
chrome/test/pyautolib/pyautolib.cc:380: LOG(FATAL) << "Automation failed: " <<
request;
No, do not make it fatal. There are tests to verify that a certain automation
command _does not_ succeed (like policy tests), in which case they catch the
JSONInterfaceError exception. That's a valid scenario.

A single failure does not mean the end of the world. It would be better to just
VLOG the request, and possibly output the time it took, since browser crashes
happen almost immediately whereas automation timeouts would take like 30 secs,
so the time's a clue.

[craigdh, 2012-05-16 21:52:21]

Please take another look.

[Nirnimesh, 2012-05-16 22:12:46]

LGTM

[commit-bot: I haz the power, 2012-05-16 22:16:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10383216/3004

[commit-bot: I haz the power, 2012-05-17 00:04:14]

Change committed as 137570