Replaced EXPECT_TRUE with a LOG(WARNING) for automation commands to provide more information...

chrome/test/pyautolib/pyautolib.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 345 matching lines @@
 }
 
 scoped_refptr<BrowserProxy> PyUITestBase::GetBrowserWindow(int window_index) {
   return automation()->GetBrowserWindow(window_index);
 }
 
 std::string PyUITestBase::_SendJSONRequest(int window_index,
                                            const std::string& request,
                                            int timeout) {
   std::string response;
+  bool response_status;
   if (window_index < 0) {  // Do not need to target a browser window.
-    EXPECT_TRUE(automation()->SendJSONRequest(request, timeout, &response));
+    response_status = automation()->SendJSONRequest(request, timeout,
+                                                    &response);
   } else {
     scoped_refptr<BrowserProxy> browser_proxy =
         automation()->GetBrowserWindow(window_index);
     EXPECT_TRUE(browser_proxy.get());
     if (browser_proxy.get()) {
-      EXPECT_TRUE(browser_proxy->SendJSONRequest(request, timeout, &response));
+      response_status = browser_proxy->SendJSONRequest(request, timeout,
+                                                       &response);
     }
   }
+  if (!response_status) {
+    LOG(FATAL) << "Automation failed: " << request;

[Nirnimesh, 2012/05/16 19:55:17]

No, do not make it fatal. There are tests to verify that a certain automation
command _does not_ succeed (like policy tests), in which case they catch the
JSONInterfaceError exception. That's a valid scenario.

A single failure does not mean the end of the world. It would be better to just
VLOG the request, and possibly output the time it took, since browser crashes
happen almost immediately whereas automation timeouts would take like 30 secs,
so the time's a clue.

+  }
   return response;
 }
 
 bool PyUITestBase::ResetToDefaultTheme() {
   return automation()->ResetToDefaultTheme();
 }
 
 bool PyUITestBase::SetCookie(const GURL& cookie_url,
                              const std::string& value,
                              int window_index,
@@ skipping 18 matching lines @@
   // TODO(phadjan.jr): figure out a way to unambiguously report error.
   if (!browser_proxy.get())
     return cookie_val;
   scoped_refptr<TabProxy> tab_proxy = browser_proxy->GetTab(tab_index);
   EXPECT_TRUE(tab_proxy.get());
   if (!tab_proxy.get())
     return cookie_val;
   EXPECT_TRUE(tab_proxy->GetCookies(cookie_url, &cookie_val));
   return cookie_val;
 }