Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: chrome/common/zip_reader.cc

Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/test_extension_service.cc ('k') | printing/pdf_metafile_skia.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/zip_reader.cc
diff --git a/chrome/common/zip_reader.cc b/chrome/common/zip_reader.cc
index 898654bcdc8e8c51922ecab1e1590840fb578fd3..a1b5b1c36953e44b5e6977500cfee80aa08c6e95 100644
--- a/chrome/common/zip_reader.cc
+++ b/chrome/common/zip_reader.cc
@@ -148,9 +148,9 @@ bool ZipReader::OpenCurrentEntryInZip() {
NULL, // szComment.
0); // commentBufferSize.
if (result != UNZ_OK)
- return NULL;
+ return false;
if (raw_file_name_in_zip[0] == '\0')
- return NULL;
+ return false;
current_entry_info_.reset(
new EntryInfo(raw_file_name_in_zip, raw_file_info));
return true;
« no previous file with comments | « chrome/browser/extensions/test_extension_service.cc ('k') | printing/pdf_metafile_skia.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698