Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: vm/assembler_x64.cc

Issue 10383189: Replace long sequences of popq with a Drop(int) macro instruction. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/assembler_x64.cc
===================================================================
--- vm/assembler_x64.cc (revision 7659)
+++ vm/assembler_x64.cc (working copy)
@@ -1266,6 +1266,13 @@
}
+void Assembler::Drop(int stack_elements) {
+ if (stack_elements > 0) {
+ addq(RSP, Immediate(stack_elements * kWordSize));
srdjan 2012/05/15 19:52:27 When is an addq better than pop? Maybe add a TODO(
Florian Schneider 2012/05/15 21:40:56 Not sure what is considered better: For i<4 pop is
+ }
srdjan 2012/05/15 19:52:27 ASSERT stack_elements >= 0?
Florian Schneider 2012/05/15 21:40:56 Done.
+}
+
+
void Assembler::LoadObject(Register dst, const Object& object) {
if (object.IsSmi()) {
movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
« vm/assembler_x64.h ('K') | « vm/assembler_x64.h ('k') | vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698