Replace long sequences of popq with a Drop(int) macro instruction.

vm/assembler_x64.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/heap.h"
 #include "vm/memory_region.h"
@@ skipping 1248 matching lines @@
     value = -value;
     if (value == 1) {
       decq(reg);
     } else if (value != 0) {
       subq(reg, Immediate(value));
     }
   }
 }
 
 
+void Assembler::Drop(int stack_elements) {
+  if (stack_elements > 0) {
+    addq(RSP, Immediate(stack_elements * kWordSize));

[srdjan, 2012/05/15 19:52:27]

When is an addq better than pop? Maybe add a TODO(fschneider)?

[Florian Schneider, 2012/05/15 21:40:56]

Not sure what is considered better: For i<4 pop is smaller, but always involves
a memory operation, whereas addq is only an ALU operation.

+  }

[srdjan, 2012/05/15 19:52:27]

ASSERT stack_elements >= 0?

[Florian Schneider, 2012/05/15 21:40:56]

Done.

+}
+
+
 void Assembler::LoadObject(Register dst, const Object& object) {
   if (object.IsSmi()) {
     movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
   } else {
     ASSERT(object.IsZoneHandle());
     AssemblerBuffer::EnsureCapacity ensured(&buffer_);
     EmitRegisterREX(dst, REX_W);
     EmitUint8(0xB8 | (dst & 7));
     buffer_.EmitObject(object);
   }
@@ skipping 223 matching lines @@
   } else {
     EmitRegisterREX(operand, REX_NONE);
   }
   EmitUint8(0xD3);
   EmitOperand(rm, Operand(operand));
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64