Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 10383117: Don't retrict the file types that can be added as bundle resources. (Closed)

Created:
8 years, 7 months ago by Marshall
Modified:
8 years, 7 months ago
Reviewers:
Robert Sesek, Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Don't retrict the file types that can be added as bundle resources.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M pylib/gyp/mac_tool.py View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marshall
Please review.
8 years, 7 months ago (2012-05-10 21:49:44 UTC) #1
Nico
I think this is fine. Robert, do you have an opinion on this?
8 years, 7 months ago (2012-05-10 22:05:21 UTC) #2
Robert Sesek
Yeah, this is fine. We can just branch early for anything that requires specific handling, ...
8 years, 7 months ago (2012-05-10 22:29:47 UTC) #3
Nico
8 years, 7 months ago (2012-05-10 22:44:21 UTC) #4
Landed in r1376. Thanks!

Powered by Google App Engine
This is Rietveld 408576698