Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/harfbuzz/src/harfbuzz-shaper.cpp

Issue 10382212: Fix the alignment issue with Arabic when a font has kerning or cursive gsub. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/harfbuzz/chromium.patch ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz/src/harfbuzz-shaper.cpp
===================================================================
--- third_party/harfbuzz/src/harfbuzz-shaper.cpp (revision 137555)
+++ third_party/harfbuzz/src/harfbuzz-shaper.cpp (working copy)
@@ -1282,16 +1282,13 @@
// (int)(positions[i].x_pos >> 6), (int)(positions[i].y_pos >> 6),
// positions[i].back, positions[i].new_advance);
- HB_Fixed adjustment = (item->item.bidiLevel % 2) ? -positions[i].x_advance : positions[i].x_advance;
+ HB_Fixed adjustment = positions[i].x_advance;
if (!(face->current_flags & HB_ShaperFlag_UseDesignMetrics))
adjustment = HB_FIXED_ROUND(adjustment);
- if (positions[i].new_advance) {
- advances[i] = adjustment;
- } else {
+ if (positions[i].new_advance == 0)
advances[i] += adjustment;
- }
int back = 0;
HB_FixedPoint *offsets = item->offsets;
@@ -1354,4 +1351,3 @@
shaper_item->glyphIndicesPresent = false;
return result;
}
-
« no previous file with comments | « third_party/harfbuzz/chromium.patch ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698