Chromium Code Reviews
Help | Chromium Project | Sign in
(348)

Issue 10382102: Fix compose-discard crasher from 11524. We can't do a call (to a generic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by Erik Corry
Modified:
1 year, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Fix compose-discard crasher from 11524. We can't do a call (to a generic
stub) unless there is a pointer map. This does not fix the 3d-raytrace
regression, that will be in another change.
Committed: https://code.google.com/p/v8/source/detail?r=11539

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Lint Patch
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +18 lines, -11 lines 4 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
Erik Corry
1 year, 11 months ago #1
Michael Starzinger
LGTM (if comments addressed). https://chromiumcodereview.appspot.com/10382102/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/10382102/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2294 src/ia32/lithium-codegen-ia32.cc:2294: if (map_count != 0) { ...
1 year, 11 months ago #2
Erik Corry
https://chromiumcodereview.appspot.com/10382102/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/10382102/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2294 src/ia32/lithium-codegen-ia32.cc:2294: if (map_count != 0) { On 2012/05/10 13:06:01, Michael ...
1 year, 11 months ago #3
Michael Starzinger
1 year, 11 months ago #4
As discussed offline, I still think my comments apply. But you already took care
of that in the follow-up cleanup CL. So LGTM if combined with the following.

https://chromiumcodereview.appspot.com/10386089/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434